8323562: SaslInputStream.read() may return wrong value

[satyenme]

Backporting JDK-8323562: SaslInputStream.read() may return wrong value. SaslInputStream.read() should return a value in the range from 0 to 255 per the spec of InputStream.read() but it returns the signed byte from the inBuf as is. Patch is clean.

---

Progress

• Change must not contain extraneous whitespace
• JDK-8323562 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8323562: SaslInputStream.read() may return wrong value (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2989/head:pull/2989
$ git checkout pull/2989

Update a local copy of the PR:
$ git checkout pull/2989
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2989/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2989

View PR using the GUI difftool:
$ git pr show -t 2989

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2989.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@satyenme This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323562: SaslInputStream.read() may return wrong value

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

• 3660c07: 8339487: ProcessHandleImpl os_getChildren sysctl call - retry in case of ENOMEM and enhance exception message
• a6b9bfe: 8321543: Update NSS to version 3.96
• a236389: 8328402: Implement pausing functionality for the PassFailJFrame
• 24e2c8a: 8315097: Rename createJavaProcessBuilder
• 48f0fa3: 8341806: Gcc version detection failure on Alinux3
• 94eaaa8: 8341688: Aarch64: Generate comments in -XX:+PrintInterpreter to link to source code
• b6685aa: 8341997: Tests create files in src tree instead of scratch dir
• 56c03a4: 8273914: Indy string concat changes order of operations
• 3d53c65: 8309109: AArch64: [TESTBUG] compiler/intrinsics/sha/cli/TestUseSHA3IntrinsicsOptionOnSupportedCPU.java fails on Neoverse N2 and V1
• b47abe8: 8325610: CTW: Add StressIncrementalInlining to stress options
• ... and 22 more: https://git.openjdk.org/jdk17u-dev/compare/b801d407e3b174d257ace832bb2301ab3a6162f3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (33aea613)

[satyenme]

/approval request Clean backport. Buggy code should return a value in the range from 0 to 255 per the spec of InputStream.read() but it returns the signed byte as is. Fix ensures we only return the lowest byte. Tested with tier1, tier2, and GHA tests. Risk is low.

[openjdk]

@satyenme
8323562: The approval request has been created successfully.

[satyenme]

/integrate

[openjdk]

@satyenme
Your change (at version 33aea61) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 3146710.
Since your change was applied there have been 32 commits pushed to the master branch:

• 3660c07: 8339487: ProcessHandleImpl os_getChildren sysctl call - retry in case of ENOMEM and enhance exception message
• a6b9bfe: 8321543: Update NSS to version 3.96
• a236389: 8328402: Implement pausing functionality for the PassFailJFrame
• 24e2c8a: 8315097: Rename createJavaProcessBuilder
• 48f0fa3: 8341806: Gcc version detection failure on Alinux3
• 94eaaa8: 8341688: Aarch64: Generate comments in -XX:+PrintInterpreter to link to source code
• b6685aa: 8341997: Tests create files in src tree instead of scratch dir
• 56c03a4: 8273914: Indy string concat changes order of operations
• 3d53c65: 8309109: AArch64: [TESTBUG] compiler/intrinsics/sha/cli/TestUseSHA3IntrinsicsOptionOnSupportedCPU.java fails on Neoverse N2 and V1
• b47abe8: 8325610: CTW: Add StressIncrementalInlining to stress options
• ... and 22 more: https://git.openjdk.org/jdk17u-dev/compare/b801d407e3b174d257ace832bb2301ab3a6162f3...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @satyenme Pushed as commit 3146710.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.