Skip to content

8273704: DrawStringWithInfiniteXform.java failed : drawString with InfiniteXform transform takes long time#3

Closed
GoeLin wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:GoeLin-backport-acceffcb
Closed

8273704: DrawStringWithInfiniteXform.java failed : drawString with InfiniteXform transform takes long time#3
GoeLin wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:GoeLin-backport-acceffcb

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 20, 2021

Backport to fix a testbug we see in 17.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273704: DrawStringWithInfiniteXform.java failed : drawString with InfiniteXform transform takes long time

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/3/head:pull/3
$ git checkout pull/3

Update a local copy of the PR:
$ git checkout pull/3
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/3/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3

View PR using the GUI difftool:
$ git pr show -t 3

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/3.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 20, 2021

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport acceffcbf73aa4416c487f890f3ca65e55e47164 8273704: DrawStringWithInfiniteXform.java failed : drawString with InfiniteXform transform takes long time Dec 20, 2021
@openjdk
Copy link

openjdk bot commented Dec 20, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Dec 20, 2021
@openjdk
Copy link

openjdk bot commented Dec 20, 2021

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273704: DrawStringWithInfiniteXform.java failed : drawString with InfiniteXform transform takes long time

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 20, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 20, 2021

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Dec 22, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Dec 22, 2021

Going to push as commit 2cac565.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 83f1749: 8273162: AbstractSplittableWithBrineGenerator does not create a random salt
  • 515d412: 8273351: bad tag in jdk.random module-info.java
  • 311bb85: 8247980: Exclusive execution of java/util/stream tests slows down tier1
  • 79d97c4: 8272327: Shenandoah: Avoid enqueuing duplicate string candidates
  • 13d3046: 8278115: gc/stress/gclocker/TestGCLockerWithSerial.java has duplicate -Xmx
  • 6634879: 8278116: runtime/modules/LoadUnloadModuleStress.java has duplicate -Xmx
  • 4b3a9e3: 8277992: Add fast jdk_svc subtests to jdk:tier3
  • cc4a0b1: 8278016: Add compiler tests to tier{2,3}
  • 5ea8f48: 8277385: Zero: Enable CompactStrings support
  • cb06a20: 8275586: Zero: Simplify interpreter initialization

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 22, 2021
@openjdk openjdk bot closed this Dec 22, 2021
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 22, 2021
@openjdk
Copy link

openjdk bot commented Dec 22, 2021

@GoeLin Pushed as commit 2cac565.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant