-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8278099: two sun/security/pkcs11/Signature tests failed with AssertionError #30
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 3adb3dd.
Your commit was automatically rebased without conflicts. |
I want to backpot this to 17u-dev as we see this in testing there, too.
Obviously it depends on the system setup.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/30/head:pull/30
$ git checkout pull/30
Update a local copy of the PR:
$ git checkout pull/30
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/30/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 30
View PR using the GUI difftool:
$ git pr show -t 30
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/30.diff