Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278099: two sun/security/pkcs11/Signature tests failed with AssertionError #30

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 22, 2021

I want to backpot this to 17u-dev as we see this in testing there, too.
Obviously it depends on the system setup.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8278099: two sun/security/pkcs11/Signature tests failed with AssertionError

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/30/head:pull/30
$ git checkout pull/30

Update a local copy of the PR:
$ git checkout pull/30
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/30/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30

View PR using the GUI difftool:
$ git pr show -t 30

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/30.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 22, 2021

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 669c90e23b2397fa9fb4388e8380c95c3b19eb48 8278099: two sun/security/pkcs11/Signature tests failed with AssertionError Dec 22, 2021
@openjdk
Copy link

openjdk bot commented Dec 22, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 22, 2021

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278099: two sun/security/pkcs11/Signature tests failed with AssertionError

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 22, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 22, 2021

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Dec 29, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Dec 29, 2021

Going to push as commit 3adb3dd.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 38fdf4f: 8276623: JDK-8275650 accidentally pushed "out" file
  • d30b6e4: 8277328: jdk/jshell/CommandCompletionTest.java failures on Windows
  • 6aa60ac: 8277441: CompileQueue::add fails with assert(_last->next() == __null) failed: not last
  • 15f2406: 8274714: Incorrect verifier protected access error message
  • 4a38659: 8274658: ISO 4217 Amendment 170 Update
  • 5287dae: 8274795: AArch64: avoid spilling and restoring r18 in macro assembler
  • d8a22d6: 8277777: [Vector API] assert(r->is_XMMRegister()) failed: must be in x86_32.ad
  • 81cd594: 8276314: [JVMCI] check alignment of call displacement during code installation

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 29, 2021
@openjdk openjdk bot closed this Dec 29, 2021
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 29, 2021
@openjdk
Copy link

openjdk bot commented Dec 29, 2021

@GoeLin Pushed as commit 3adb3dd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant