8332901: Select{Current,New}ItemTest.java for Choice don't open popup on macOS

[GoeLin]

I backport this for parity with 17.0.14-oracle

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8332901 needs maintainer approval

Issue

• JDK-8332901: Select{Current,New}ItemTest.java for Choice don't open popup on macOS (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3013/head:pull/3013
$ git checkout pull/3013

Update a local copy of the PR:
$ git checkout pull/3013
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3013/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3013

View PR using the GUI difftool:
$ git pr show -t 3013

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3013.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332901: Select{Current,New}ItemTest.java for Choice don't open popup on macOS

Move SelectCurrentItemTest.java to java/awt/Choice/SelectItem/.
Move SelectNewItemTest.java to java/awt/Choice/SelectItem/.
Use latches to control test flow instead of delays.
Encapsulate the common logic in SelectCurrentItemTest.
Provide overridable checkXXX() methods to modify conditions.
Provide an overridable method which defines where to click
in the choice popup to select an item.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue and summary from the original commit.

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (47d6a1cb)

[GoeLin]

/integrate

[openjdk]

Going to push as commit 5fe6cf8.
Since your change was applied there have been 10 commits pushed to the master branch:

• 7faedc6: 8336240: Test com/sun/crypto/provider/Cipher/DES/PerformanceTest.java fails with java.lang.ArithmeticException
• edee2e9: 8335709: C2: assert(!loop->is_member(get_loop(useblock))) failed: must be outside loop
• 0494928: 8325851: Hide PassFailJFrame.Builder constructor
• 498d236: 8327474: Review use of java.io.tmpdir in jdk tests
• 4d147bf: 8328379: Convert URLDragTest.html applet test to main
• c436edb: 8342962: [s390x] TestOSRLotsOfLocals.java crashes
• af17bf4: 8283214: [macos] Screen magnifier does not show the magnified text for JComboBox
• e52902e: 8310072: JComboBox/DisabledComboBoxFontTestAuto: Enabled and disabled ComboBox does not match in these LAFs: GTK+
• 467231b: 8342701: [PPC64] TestOSRLotsOfLocals.java crashes
• a72e14a: 7093691: Nimbus LAF: disabled JComboBox using renderer has bad font color

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit 5fe6cf8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.