8325851: Hide PassFailJFrame.Builder constructor

[GoeLin]

I backport this for parity with 17.0.14-oracle.

I omit the changes to AcceleratorTest as 8315701: [macos] Regression: KeyEvent has different keycode on different keyboard layouts
is not in 17.
The test does not use PassFailJFrame yet.

Testing: All tests for linux and mac start up.
Double checked two windows tests.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8325851 needs maintainer approval

Issue

• JDK-8325851: Hide PassFailJFrame.Builder constructor (Bug - P5 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer) Review applies to ed3eb1ec
• Lutz Schmidt (@RealLucy - Reviewer) Review applies to ed3eb1ec
• Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3014/head:pull/3014
$ git checkout pull/3014

Update a local copy of the PR:
$ git checkout pull/3014
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3014/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3014

View PR using the GUI difftool:
$ git pr show -t 3014

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3014.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into pr/3012 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325851: Hide PassFailJFrame.Builder constructor

Reviewed-by: mbaesken, phh, lucy
Backport-of: 3b9255eb663b4c90aa5cec89f0d9380ef8eba49e

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 498d236: 8327474: Review use of java.io.tmpdir in jdk tests

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full - Incremental (ba7f04e8)
• 01: Full - Incremental (ed3eb1ec)
• 00: Full (ed3eb1ec)

[RealLucy]

LGTM.

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout goetz_backport_8325851
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[GoeLin]

/integrate

[openjdk]

@GoeLin This pull request has not yet been marked as ready for integration.

[GoeLin]

/integrate

[openjdk]

Going to push as commit 0494928.
Since your change was applied there has been 1 commit pushed to the master branch:

• 498d236: 8327474: Review use of java.io.tmpdir in jdk tests

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit 0494928.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.