8313374: --enable-ccache's CCACHE_BASEDIR breaks builds

[sendaoYan]

Hi all,

This pull request contains a backport of commit 571c435e from the openjdk/jdk repository.

The commit being backported was authored by Jan Kratochvil on 23 Aug 2023 and was reviewed by Erik Joelsson.

Without this PR, the jdk build with --enable-ccache can't generate comments in -XX:+PrintInterpreter, this PR fix the build issue. So I want to backport this PR to jdk17u-dev from jdk22.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8313374 needs maintainer approval

Issue

• JDK-8313374: --enable-ccache's CCACHE_BASEDIR breaks builds (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3015/head:pull/3015
$ git checkout pull/3015

Update a local copy of the PR:
$ git checkout pull/3015
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3015/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3015

View PR using the GUI difftool:
$ git pr show -t 3015

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3015.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313374: --enable-ccache's CCACHE_BASEDIR breaks builds

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

• 9ae66af: 8195675: Call to insertText with single character from custom Input Method ignored
• 2a9bd22: 8342578: GHA: RISC-V: Bootstrap using Debian snapshot is still failing
• 00fa4df: 8340466: Add description for PassFailJFrame constructors
• 51aec1a: 8340899: Remove wildcard bound in PositionWindows.positionTestWindows
• 0881378: 8340684: Reading from an input stream backed by a closed ZipFile has no test coverage
• 7caf756: 8340365: Position the first window of a window list
• bd4c65d: 8340461: Amend description for logArea
• 17f35ba: 8340308: PassFailJFrame: Make rows default to number of lines in instructions
• 5e3c5d9: 8339787: Add some additional diagnostic output to java/net/ipv6tests/UdpTest.java
• 856b483: 8340306: Add border around instructions in PassFailJFrame
• ... and 13 more: https://git.openjdk.org/jdk17u-dev/compare/70a227fe5a223939b95675e019c6f3db23b38755...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[sendaoYan]

/approval request Clean backport to fix build bug with --enable-ccache. Without this PR, the jdk build with --enable-ccache can't generate comments with JVM option -XX:+PrintInterpreter, this PR will fix the build issue. So I want to backport this PR to jdk17u-dev from jdk22.

[mlbridge]

Webrevs

• 00: Full (c8685519)

[openjdk]

@sendaoYan
8313374: The approval request has been created successfully.

[sendaoYan]

Thanks for the approval.

/integrate

[openjdk]

@sendaoYan
Your change (at version c868551) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 18ea311.
Since your change was applied there have been 30 commits pushed to the master branch:

• 955bae2: 8342496: C2/Shenandoah: SEGV in compiled code when running jcstress
• a7fc50c: 8337066: Repeated call of StringBuffer.reverse with double byte string returns wrong result
• 59fcc3c: 8340785: Update description of PassFailJFrame and samples
• fadfa58: 8317116: Provide layouts for multiple test UI in PassFailJFrame
• 4c89a63: 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts
• ead9446: 8332340: Add JavacBench as a test case for CDS
• 5fada95: 8339931: Update problem list for WindowUpdateFocusabilityTest.java
• 9ae66af: 8195675: Call to insertText with single character from custom Input Method ignored
• 2a9bd22: 8342578: GHA: RISC-V: Bootstrap using Debian snapshot is still failing
• 00fa4df: 8340466: Add description for PassFailJFrame constructors
• ... and 20 more: https://git.openjdk.org/jdk17u-dev/compare/70a227fe5a223939b95675e019c6f3db23b38755...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @sendaoYan Pushed as commit 18ea311.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[sendaoYan]

Thanks for the sponsor.