Skip to content

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Nov 5, 2024

Hi all,

This pull request contains a backport of commit 8bcd4920 from the openjdk/jdk repository.

The commit being backported was authored by SendaoYan on 22 Oct 2024 and was reviewed by Aleksey Shipilev.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8342681 needs maintainer approval

Issue

  • JDK-8342681: TestLoadBypassesNullCheck.java fails improperly specified VM option (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3027/head:pull/3027
$ git checkout pull/3027

Update a local copy of the PR:
$ git checkout pull/3027
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3027/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3027

View PR using the GUI difftool:
$ git pr show -t 3027

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3027.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 5, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 5, 2024

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342681: TestLoadBypassesNullCheck.java fails improperly specified VM option

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@sendaoYan
Copy link
Member Author

/approval request Clean backport to fix the test bug which cause test run failed by release jdk build. Test-fix only, no risk.

@openjdk openjdk bot changed the title Backport 8bcd4920f1b03d0ef8e295e53557c629f05ceaa4 8342681: TestLoadBypassesNullCheck.java fails improperly specified VM option Nov 5, 2024
@openjdk
Copy link

openjdk bot commented Nov 5, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 5, 2024
@openjdk
Copy link

openjdk bot commented Nov 5, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 5, 2024
@openjdk
Copy link

openjdk bot commented Nov 5, 2024

@sendaoYan
8342681: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Nov 5, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 5, 2024

Webrevs

@sendaoYan
Copy link
Member Author

GHA report a failure wget exited with exit code 4 on linux-x64 at Get JTReg stage, seems environmental issue, it's unreleated to this issue.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Nov 5, 2024
@sendaoYan
Copy link
Member Author

Thanks for the approved.

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 5, 2024
@openjdk
Copy link

openjdk bot commented Nov 5, 2024

@sendaoYan
Your change (at version 5915222) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 5, 2024

Going to push as commit 5819d91.
Since your change was applied there have been 3 commits pushed to the master branch:

  • b0c75b4: 8341235: Improve default instruction frame title in PassFailJFrame
  • eb46442: 8340799: Add border inside instruction frame in PassFailJFrame
  • d1be3c9: 8340812: LambdaForm customization via MethodHandle::updateForm is not thread safe

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 5, 2024
@openjdk openjdk bot closed this Nov 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 5, 2024
@openjdk
Copy link

openjdk bot commented Nov 5, 2024

@phohensee @sendaoYan Pushed as commit 5819d91.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan
Copy link
Member Author

Thanks for the sponsor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants