-
Notifications
You must be signed in to change notification settings - Fork 232
8342681: TestLoadBypassesNullCheck.java fails improperly specified VM option #3027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8342681: TestLoadBypassesNullCheck.java fails improperly specified VM option #3027
Conversation
|
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
|
@sendaoYan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
/approval request Clean backport to fix the test bug which cause test run failed by release jdk build. Test-fix only, no risk. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
@sendaoYan |
|
GHA report a failure |
|
Thanks for the approved. /integrate |
|
@sendaoYan |
|
/sponsor |
|
Going to push as commit 5819d91.
Your commit was automatically rebased without conflicts. |
|
@phohensee @sendaoYan Pushed as commit 5819d91. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
|
Thanks for the sponsor. |
Hi all,
This pull request contains a backport of commit 8bcd4920 from the openjdk/jdk repository.
The commit being backported was authored by SendaoYan on 22 Oct 2024 and was reviewed by Aleksey Shipilev.
Thanks!
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3027/head:pull/3027$ git checkout pull/3027Update a local copy of the PR:
$ git checkout pull/3027$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3027/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3027View PR using the GUI difftool:
$ git pr show -t 3027Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3027.diff
Using Webrev
Link to Webrev Comment