Skip to content

8207908: JMXStatusTest.java fails assertion intermittently #3042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Nov 15, 2024

Hi all,

This pull request contains a backport of commit b7d0eff5 from the openjdk/jdk repository.

The commit being backported was authored by Kevin Walls on 11 Jul 2024 and was reviewed by Chris Plummer and Alex Menkov.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8207908 needs maintainer approval

Issue

  • JDK-8207908: JMXStatusTest.java fails assertion intermittently (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3042/head:pull/3042
$ git checkout pull/3042

Update a local copy of the PR:
$ git checkout pull/3042
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3042/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3042

View PR using the GUI difftool:
$ git pr show -t 3042

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3042.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 15, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 15, 2024

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8207908: JMXStatusTest.java fails assertion intermittently

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 49b1ca9: 8300416: java.security.MessageDigestSpi clone can result in thread-unsafe clones

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport d0abff2f0745aa135cc9dbf6def4f260b634f107 8207908: JMXStatusTest.java fails assertion intermittently Nov 15, 2024
@openjdk
Copy link

openjdk bot commented Nov 15, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 15, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 15, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 15, 2024

Webrevs

@sendaoYan
Copy link
Member Author

GHA report 3 failures:

  1. linux-x64 build debug job at Get JTReg stage fails wget exited with exit code 4 seems like infra issue or environmental issue, it's unrelated to this PR.
  2. macos-aarch64 build debug job at install toolchain depedencies stage fails xcode-select: error: invalid developer directory seems like infra issue or environmental issue, it's unrelated to this PR.
  3. macos-aarch64 build release job at install toolchain depedencies stage fails xcode-select: error: invalid developer directory seems like infra issue or environmental issue, it's unrelated to this PR.

@sendaoYan
Copy link
Member Author

/approval request Clean backport to fix the test bug which cause test intermittent fails run with simultaneously, and this is prefixed backport of JDK-8336257. The change has been verified locally, which run the test 100 times simultaneously, test-fix only, no risk.

@openjdk
Copy link

openjdk bot commented Nov 15, 2024

@sendaoYan
8207908: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Nov 15, 2024
@sendaoYan
Copy link
Member Author

Thanks for the approved.

/integrate

@openjdk
Copy link

openjdk bot commented Nov 18, 2024

Going to push as commit 6d7a6e1.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 8989bab: 8298513: vmTestbase/nsk/jdi/EventSet/suspendPolicy/suspendpolicy009/TestDescription.java fails with usage tracker
  • b1fae1c: 8292309: Fix java/awt/PrintJob/ConstrainedPrintingTest/ConstrainedPrintingTest.java test
  • 4b74741: 8284291: sun/security/krb5/auto/Renew.java fails intermittently on Windows 11
  • e486000: 8258734: jdk/jfr/event/oldobject/TestClassLoaderLeak.java failed with "RuntimeException: Could not find class leak"
  • 49b1ca9: 8300416: java.security.MessageDigestSpi clone can result in thread-unsafe clones

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 18, 2024
@openjdk openjdk bot closed this Nov 18, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 18, 2024
@openjdk
Copy link

openjdk bot commented Nov 18, 2024

@sendaoYan Pushed as commit 6d7a6e1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant