8319640: ClassicFormat::parseObject (from DateTimeFormatter) does not conform to the javadoc and may leak DateTimeException

[pengxiaolong]

Hi all,

This pull request contains a backport of commit fe0ccdf5 from the openjdk/jdk repository.

The commit being backported was authored by Naoto Sato on 13 Nov 2023 and was reviewed by Roger Riggs, Iris Clark, Justin Lu and Joe Wang.

Tese:

• CONF=linux-x86_64-server-fastdebug make test TEST=jdk/\* JTREG_KEYWORDS=\!headful, there are failures caused by missing printer for test, not related this change.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• JDK-8319640 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8319640: ClassicFormat::parseObject (from DateTimeFormatter) does not conform to the javadoc and may leak DateTimeException (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3059/head:pull/3059
$ git checkout pull/3059

Update a local copy of the PR:
$ git checkout pull/3059
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3059/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3059

View PR using the GUI difftool:
$ git pr show -t 3059

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3059.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back xpeng! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@pengxiaolong This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319640: ClassicFormat::parseObject (from DateTimeFormatter) does not conform to the javadoc and may leak DateTimeException

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 44 new commits pushed to the master branch:

• a44a35e: 8342181: Update tests to use stronger Key and Salt size
• c4ea7b4: 8325525: Create jtreg test case for JDK-8325203
• 7575163: 8274170: Add hooks for custom makefiles to augment jtreg test execution
• dcac5eb: 8328619: sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.java failed with BindException: Address already in use
• 4ea9694: 8341927: Replace hardcoded security providers with new test.provider.name system property
• cd3a614: 8322766: Micro bench SSLHandshake should use default algorithms
• 6012693: 8254759: [TEST_BUG] [macosx] javax/swing/JInternalFrame/4202966/IntFrameCoord.html fails
• 848d8e8: 8336257: Additional tests in jmxremote/startstop to match on PID not app name
• 73d6539: 8328697: SubMenuShowTest and SwallowKeyEvents tests stabilization
• b88676d: 8317738: CodeCacheFullCountTest failed with "VirtualMachineError: Out of space in CodeCache for method handle intrinsic"
• ... and 34 more: https://git.openjdk.org/jdk17u-dev/compare/955bae2b03055552237584aa7c68b1afcfa3b9c1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @pengxiaolong This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[pengxiaolong]

/approval request Backport 8319640: ClassicFormat::parseObject (from DateTimeFormatter) does not conform to the javadoc and may leak DateTimeException, applied cleanly, bug fix, overall risk should be low, I have run all the test in under jdk/ including the new unit test added for this fix.

[mlbridge]

Webrevs

• 00: Full (d65648e9)

[openjdk]

@pengxiaolong
8319640: The approval request has been created successfully.

[pengxiaolong]

Thanks for the review and approval.

/integrate

[openjdk]

@pengxiaolong
Your change (at version d65648e) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit e0dd517.
Since your change was applied there have been 44 commits pushed to the master branch:

• a44a35e: 8342181: Update tests to use stronger Key and Salt size
• c4ea7b4: 8325525: Create jtreg test case for JDK-8325203
• 7575163: 8274170: Add hooks for custom makefiles to augment jtreg test execution
• dcac5eb: 8328619: sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.java failed with BindException: Address already in use
• 4ea9694: 8341927: Replace hardcoded security providers with new test.provider.name system property
• cd3a614: 8322766: Micro bench SSLHandshake should use default algorithms
• 6012693: 8254759: [TEST_BUG] [macosx] javax/swing/JInternalFrame/4202966/IntFrameCoord.html fails
• 848d8e8: 8336257: Additional tests in jmxremote/startstop to match on PID not app name
• 73d6539: 8328697: SubMenuShowTest and SwallowKeyEvents tests stabilization
• b88676d: 8317738: CodeCacheFullCountTest failed with "VirtualMachineError: Out of space in CodeCache for method handle intrinsic"
• ... and 34 more: https://git.openjdk.org/jdk17u-dev/compare/955bae2b03055552237584aa7c68b1afcfa3b9c1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @pengxiaolong Pushed as commit e0dd517.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.