Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Nov 20, 2024

I backport this for parity with 17.0.13-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8336315 needs maintainer approval
  • JDK-8325525 needs maintainer approval

Issues

  • JDK-8325525: Create jtreg test case for JDK-8325203 (Enhancement - P4 - Approved)
  • JDK-8336315: tools/jpackage/windows/WinChildProcessTest.java Failed: Check is calculator process is alive (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3065/head:pull/3065
$ git checkout pull/3065

Update a local copy of the PR:
$ git checkout pull/3065
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3065/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3065

View PR using the GUI difftool:
$ git pr show -t 3065

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3065.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 20, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 20, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325525: Create jtreg test case for JDK-8325203
8336315: tools/jpackage/windows/WinChildProcessTest.java Failed: Check is calculator process is alive

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • dcac5eb: 8328619: sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.java failed with BindException: Address already in use
  • 4ea9694: 8341927: Replace hardcoded security providers with new test.provider.name system property
  • cd3a614: 8322766: Micro bench SSLHandshake should use default algorithms
  • 6012693: 8254759: [TEST_BUG] [macosx] javax/swing/JInternalFrame/4202966/IntFrameCoord.html fails
  • 848d8e8: 8336257: Additional tests in jmxremote/startstop to match on PID not app name

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 936b23953044d0c9a8ea558208c3cd503895144a 8325525: Create jtreg test case for JDK-8325203 Nov 20, 2024
@openjdk
Copy link

openjdk bot commented Nov 20, 2024

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 20, 2024
@openjdk
Copy link

openjdk bot commented Nov 20, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received rfr Pull request is ready for review labels Nov 20, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 20, 2024

Webrevs

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received and removed approval Requires approval; will be removed when approval is received labels Nov 21, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Nov 21, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Nov 21, 2024

@GoeLin This pull request has not yet been marked as ready for integration.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Nov 22, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Nov 22, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Nov 22, 2024

Going to push as commit c4ea7b4.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 7575163: 8274170: Add hooks for custom makefiles to augment jtreg test execution
  • dcac5eb: 8328619: sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.java failed with BindException: Address already in use
  • 4ea9694: 8341927: Replace hardcoded security providers with new test.provider.name system property
  • cd3a614: 8322766: Micro bench SSLHandshake should use default algorithms
  • 6012693: 8254759: [TEST_BUG] [macosx] javax/swing/JInternalFrame/4202966/IntFrameCoord.html fails
  • 848d8e8: 8336257: Additional tests in jmxremote/startstop to match on PID not app name

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 22, 2024
@openjdk openjdk bot closed this Nov 22, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 22, 2024
@openjdk
Copy link

openjdk bot commented Nov 22, 2024

@GoeLin Pushed as commit c4ea7b4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant