Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8339892: Several security shell tests don't set TESTJAVAOPTS #3081

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 2, 2024

I backport this for parity with 17.0.14-oracle.

Resolved one Copyright, probably clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8339892 needs maintainer approval

Issue

  • JDK-8339892: Several security shell tests don't set TESTJAVAOPTS (Sub-task - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3081/head:pull/3081
$ git checkout pull/3081

Update a local copy of the PR:
$ git checkout pull/3081
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3081/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3081

View PR using the GUI difftool:
$ git pr show -t 3081

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3081.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 2, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 2, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339892: Several security shell tests don't set TESTJAVAOPTS

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 20927ac: 8331863: DUIterator_Fast used before it is constructed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 8a2a75e56de4497da48f43b3be3eb71bf3ef75ab 8339892: Several security shell tests don't set TESTJAVAOPTS Dec 2, 2024
@openjdk
Copy link

openjdk bot commented Dec 2, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 2, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 2, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 2, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Dec 3, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Dec 3, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Dec 3, 2024

Going to push as commit f23d6bf.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 4d268db: 8322809: SystemModulesMap::classNames and moduleNames arrays do not match the order
  • 20927ac: 8331863: DUIterator_Fast used before it is constructed

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 3, 2024
@openjdk openjdk bot closed this Dec 3, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 3, 2024
@openjdk
Copy link

openjdk bot commented Dec 3, 2024

@GoeLin Pushed as commit f23d6bf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8339892 branch December 3, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant