Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8308341: JNI_GetCreatedJavaVMs returns a partially initialized JVM #3084

Closed
wants to merge 2 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 2, 2024

I backport this for parity with 17.0.15-oracle.

I had to resolve the makefile.
Also, I had to resolve jni.cpp because of nullptr in the context.

I include follow-up JDK-8309171, this applies after adding the problemlisting JDK-8309231.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8308341 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Change requires CSR request JDK-8342970 to be approved
  • Commit message must refer to an issue
  • JDK-8309171 needs maintainer approval
  • JDK-8309231 needs maintainer approval

Issues

  • JDK-8308341: JNI_GetCreatedJavaVMs returns a partially initialized JVM (Bug - P3 - Approved)
  • JDK-8309231: ProblemList vmTestbase/nsk/jvmti/scenarios/jni_interception/JI05/ji05t001/TestDescription.java (Sub-task - P2 - Approved)
  • JDK-8309171: Test vmTestbase/nsk/jvmti/scenarios/jni_interception/JI05/ji05t001/TestDescription.java fails after JDK-8308341 (Bug - P2 - Approved)
  • JDK-8342970: JNI_GetCreatedJavaVMs returns a partially initialized JVM (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3084/head:pull/3084
$ git checkout pull/3084

Update a local copy of the PR:
$ git checkout pull/3084
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3084/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3084

View PR using the GUI difftool:
$ git pr show -t 3084

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3084.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 2, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 2, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308341: JNI_GetCreatedJavaVMs returns a partially initialized JVM
8309231: ProblemList vmTestbase/nsk/jvmti/scenarios/jni_interception/JI05/ji05t001/TestDescription.java
8309171: Test vmTestbase/nsk/jvmti/scenarios/jni_interception/JI05/ji05t001/TestDescription.java fails after JDK-8308341

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 63aa076: 8345371: Bump update version for OpenJDK: jdk-17.0.15
  • bdc07d2: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files
  • f23d6bf: 8339892: Several security shell tests don't set TESTJAVAOPTS
  • 4d268db: 8322809: SystemModulesMap::classNames and moduleNames arrays do not match the order
  • 20927ac: 8331863: DUIterator_Fast used before it is constructed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 1e6770fb978e630b38a70a05120c50f723bb66dc 8308341: JNI_GetCreatedJavaVMs returns a partially initialized JVM Dec 2, 2024
@openjdk
Copy link

openjdk bot commented Dec 2, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Dec 2, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Dec 2, 2024

/issue JDK-8309231

@GoeLin
Copy link
Member Author

GoeLin commented Dec 2, 2024

/issue JDK-8309171

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 2, 2024
@openjdk
Copy link

openjdk bot commented Dec 2, 2024

@GoeLin
Adding additional issue to issue list: 8309231: ProblemList vmTestbase/nsk/jvmti/scenarios/jni_interception/JI05/ji05t001/TestDescription.java.

@openjdk
Copy link

openjdk bot commented Dec 2, 2024

@GoeLin
Adding additional issue to issue list: 8309171: Test vmTestbase/nsk/jvmti/scenarios/jni_interception/JI05/ji05t001/TestDescription.java fails after JDK-8308341.

@mlbridge
Copy link

mlbridge bot commented Dec 2, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 2, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original change bumps the Copyright year in JtregNativeHotspot.gmk. It would be better to do the same.
What's the point regarding the ProblemList? Does one part add it and the other one remove it, so it's a nop?

@phohensee
Copy link
Member

It appeared to me that indeed one part added it and one removed it.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Dec 4, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Dec 4, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Dec 4, 2024

Going to push as commit ed63b71.
Since your change was applied there have been 7 commits pushed to the master branch:

  • be22b1a: 8299739: HashedPasswordFileTest.java and ExceptionTest.java can fail with java.lang.NullPointerException
  • c1a9356: 8299077: [REDO] JDK-4512626 Non-editable JTextArea provides no visual indication of keyboard focus
  • 63aa076: 8345371: Bump update version for OpenJDK: jdk-17.0.15
  • bdc07d2: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files
  • f23d6bf: 8339892: Several security shell tests don't set TESTJAVAOPTS
  • 4d268db: 8322809: SystemModulesMap::classNames and moduleNames arrays do not match the order
  • 20927ac: 8331863: DUIterator_Fast used before it is constructed

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 4, 2024
@openjdk openjdk bot closed this Dec 4, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 4, 2024
@openjdk
Copy link

openjdk bot commented Dec 4, 2024

@GoeLin Pushed as commit ed63b71.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8308341 branch December 4, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants