-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8308341: JNI_GetCreatedJavaVMs returns a partially initialized JVM #3084
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
/issue JDK-8309231 |
/issue JDK-8309171 |
@GoeLin |
@GoeLin |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original change bumps the Copyright year in JtregNativeHotspot.gmk. It would be better to do the same.
What's the point regarding the ProblemList? Does one part add it and the other one remove it, so it's a nop?
It appeared to me that indeed one part added it and one removed it. |
/integrate |
Going to push as commit ed63b71.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 17.0.15-oracle.
I had to resolve the makefile.
Also, I had to resolve jni.cpp because of nullptr in the context.
I include follow-up JDK-8309171, this applies after adding the problemlisting JDK-8309231.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3084/head:pull/3084
$ git checkout pull/3084
Update a local copy of the PR:
$ git checkout pull/3084
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3084/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3084
View PR using the GUI difftool:
$ git pr show -t 3084
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3084.diff
Using Webrev
Link to Webrev Comment