Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272908: Missing coverage for certain classes in com.sun.org.apache.xml.internal.security #309

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Mar 30, 2022

Clean backport of JDK-8272908


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8272908: Missing coverage for certain classes in com.sun.org.apache.xml.internal.security

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/309/head:pull/309
$ git checkout pull/309

Update a local copy of the PR:
$ git checkout pull/309
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/309/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 309

View PR using the GUI difftool:
$ git pr show -t 309

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/309.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 30, 2022

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a16f2d0a3c326dd8b3b2133a9c170d998b7aa631 8272908: Missing coverage for certain classes in com.sun.org.apache.xml.internal.security Mar 30, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Mar 30, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 30, 2022

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272908: Missing coverage for certain classes in com.sun.org.apache.xml.internal.security

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Mar 30, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 30, 2022

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

@TheRealMDoerr TheRealMDoerr commented Mar 31, 2022

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Mar 31, 2022

Going to push as commit 789b4a9.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 2d6247b: 8272964: java/nio/file/Files/InterruptCopy.java fails with java.lang.RuntimeException: Copy was not interrupted
  • 079119a: 8272493: Suboptimal code generation around Preconditions.checkIndex intrinsic with AVX2
  • 9c3124a: 8283408: Fix a C2 crash when filling arrays with unsafe
  • 3127e4c: 8282172: CompileBroker::log_metaspace_failure is called from non-Java/compiler threads
  • e2f6bb8: 8280867: Cpuid1Ecx feature parsing is incorrect for AMD CPUs

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Mar 31, 2022
@openjdk openjdk bot closed this Mar 31, 2022
@openjdk openjdk bot removed ready rfr labels Mar 31, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Mar 31, 2022

@TheRealMDoerr Pushed as commit 789b4a9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant