-
Notifications
You must be signed in to change notification settings - Fork 224
8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic #3092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 16 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
Hi @martinuy |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution. Looks good to me.
Thanks for the reviews! |
/integrate |
Going to push as commit 6f16a44.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 17.0.15-oracle.
Config.java:
Resolve and adapt because of unsupported switch syntax.
SunPKCS11.java: I had to resolve becuase
"8301553: Support Password-Based Cryptography in SunPKCS11"
is not in 17. Context code has different control flow.
Patched code is unchanged.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3092/head:pull/3092
$ git checkout pull/3092
Update a local copy of the PR:
$ git checkout pull/3092
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3092/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3092
View PR using the GUI difftool:
$ git pr show -t 3092
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3092.diff
Using Webrev
Link to Webrev Comment