Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 4, 2024

I backport this for parity with 17.0.15-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8336012 needs maintainer approval

Issue

  • JDK-8336012: Fix usages of jtreg-reserved properties (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3095/head:pull/3095
$ git checkout pull/3095

Update a local copy of the PR:
$ git checkout pull/3095
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3095/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3095

View PR using the GUI difftool:
$ git pr show -t 3095

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3095.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 4, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 4, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8336012: Fix usages of jtreg-reserved properties

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport e6c5aa7a6cb54c647d261facdcffa6a410849627 8336012: Fix usages of jtreg-reserved properties Dec 4, 2024
@openjdk
Copy link

openjdk bot commented Dec 4, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Dec 4, 2024
@openjdk
Copy link

openjdk bot commented Dec 4, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 4, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 4, 2024

Webrevs

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Dec 6, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Dec 6, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Dec 6, 2024

Going to push as commit 98526a6.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 3c7596f: 8335789: [TESTBUG] XparColor.java test fails with Error. Parse Exception: Invalid or unrecognized bugid: @
  • 4f2f67d: 8334490: Normalize string with locale invariant toLowerCase()
  • 34d3185: 8327857: Remove applet usage from JColorChooser tests Test4222508
  • 2c64d33: 8319648: java/lang/SecurityManager tests ignore vm flags
  • 964c828: 8319673: Few security tests ignore VM flags
  • b90bb12: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump
  • 81e55d3: 8319647: Few java/lang/System/LoggerFinder/modules tests ignore vm flags
  • b90cef2: 8319569: Several java/util tests should be updated to accept VM flags
  • fc658cc: 8286779: javax.crypto.CryptoPolicyParser#isConsistent always returns 'true'

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 6, 2024
@openjdk openjdk bot closed this Dec 6, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 6, 2024
@openjdk
Copy link

openjdk bot commented Dec 6, 2024

@GoeLin Pushed as commit 98526a6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant