Skip to content

8343129: Disable unstable check of ThreadsListHandle.sanity_vm ThreadList values #3108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Dec 12, 2024

Hi all,

This pull request contains a backport of commit 59fcfae6 from the openjdk/jdk repository.

The commit being backported was authored by SendaoYan on 19 Nov 2024 and was reviewed by David Holmes.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8343129 needs maintainer approval

Issue

  • JDK-8343129: Disable unstable check of ThreadsListHandle.sanity_vm ThreadList values (Sub-task - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3108/head:pull/3108
$ git checkout pull/3108

Update a local copy of the PR:
$ git checkout pull/3108
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3108/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3108

View PR using the GUI difftool:
$ git pr show -t 3108

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3108.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 12, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 12, 2024

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343129: Disable unstable check of ThreadsListHandle.sanity_vm ThreadList values

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 45ee88f: 8314909: tools/jpackage/windows/Win8282351Test.java fails with java.lang.AssertionError: Expected [0]. Actual [1618]:
  • ff496b9: 8320916: jdk/jfr/event/gc/stacktrace/TestParallelMarkSweepAllocationPendingStackTrace.java failed with "OutOfMemoryError: GC overhead limit exceeded"
  • 8c2f28a: 8343100: Consolidate EmptyFolderTest and EmptyFolderPackageTest jpackage tests into single java file
  • c12baf1: 8299994: java/security/Policy/Root/Root.java fails when home directory is read-only

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 59fcfae63090f6659a94a9e3dd0705739ec1b074 8343129: Disable unstable check of ThreadsListHandle.sanity_vm ThreadList values Dec 12, 2024
@openjdk
Copy link

openjdk bot commented Dec 12, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 12, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 12, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 12, 2024

Webrevs

@sendaoYan
Copy link
Member Author

sendaoYan commented Dec 12, 2024

/approval request Disable unstable check ThreadsListHandle.sanity_vm in gtest, test-fix only, no risk.

@openjdk
Copy link

openjdk bot commented Dec 12, 2024

@sendaoYan
8343129: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Dec 12, 2024
@sendaoYan
Copy link
Member Author

/approval request Disable unstable check ThreadsListHandle.sanity_vm in gtest, test-fix only, no risk.

@openjdk
Copy link

openjdk bot commented Dec 12, 2024

@sendaoYan
8343129: The approval request has been updated successfully.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 16, 2024
@sendaoYan
Copy link
Member Author

Thanks for the approved.

/integrate

@openjdk
Copy link

openjdk bot commented Dec 16, 2024

Going to push as commit 9c126b3.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 7db0131: 8325906: Problemlist vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize/Test.java#id1 until JDK-8320865 is fixed
  • 25140d1: 8318442: java/net/httpclient/ManyRequests2.java fails intermittently on Linux
  • 45ee88f: 8314909: tools/jpackage/windows/Win8282351Test.java fails with java.lang.AssertionError: Expected [0]. Actual [1618]:
  • ff496b9: 8320916: jdk/jfr/event/gc/stacktrace/TestParallelMarkSweepAllocationPendingStackTrace.java failed with "OutOfMemoryError: GC overhead limit exceeded"
  • 8c2f28a: 8343100: Consolidate EmptyFolderTest and EmptyFolderPackageTest jpackage tests into single java file
  • c12baf1: 8299994: java/security/Policy/Root/Root.java fails when home directory is read-only

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 16, 2024
@openjdk openjdk bot closed this Dec 16, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 16, 2024
@openjdk
Copy link

openjdk bot commented Dec 16, 2024

@sendaoYan Pushed as commit 9c126b3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant