Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 17, 2024

I backport this for parity with 17.0.15-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8328185 needs maintainer approval

Issue

  • JDK-8328185: Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3131/head:pull/3131
$ git checkout pull/3131

Update a local copy of the PR:
$ git checkout pull/3131
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3131/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3131

View PR using the GUI difftool:
$ git pr show -t 3131

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3131.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 17, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 17, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328185: Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • 3f1ba56: 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed
  • 6400a16: 8341978: Improve JButton/bug4490179.java
  • e3b2638: 8331959: Update PKCS#11 Cryptographic Token Interface to v3.1
  • 159bd1c: 8339902: Open source couple TextField related tests
  • fb37a91: 8339687: Rearrange reachabilityFence()s in jdk.test.lib.util.ForceGC
  • 71d5c0b: 8338100: C2: assert(!n_loop->is_member(get_loop(lca))) failed: control must not be back in the loop
  • 585297d: 8336498: [macos] [build]: install-file macro may run into permission denied error
  • f706c24: 8333391: Test com/sun/jdi/InterruptHangTest.java failed: Thread was never interrupted during sleep
  • b532a4a: 8336692: Redo fix for JDK-8284620
  • 9b9027c: 8334777: Test javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java failed with NullPointerException
  • ... and 8 more: https://git.openjdk.org/jdk17u-dev/compare/9c126b3c86860e98b40e3a2a8b576760d80e0389...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 4e83f4cfc779e39cca0070b5729a508aeaa74654 8328185: Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main Dec 17, 2024
@openjdk
Copy link

openjdk bot commented Dec 17, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Dec 17, 2024
@openjdk
Copy link

openjdk bot commented Dec 17, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 17, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 17, 2024

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Dec 18, 2024

GHA failure: well known wget issue, unrelated.
mac: Error: fatal: unable to access 'https://github.com/openjdk-bots/jdk17u-dev/': The requested URL returned error: 503
also unrelated.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Dec 18, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Dec 18, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Dec 18, 2024

Going to push as commit 7d8dd1b.
Since your change was applied there have been 19 commits pushed to the master branch:

  • 219afaf: 8320714: java/util/Locale/LocaleProvidersRun.java and java/util/ResourceBundle/modules/visibility/VisibilityTest.java timeout after passing
  • 3f1ba56: 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed
  • 6400a16: 8341978: Improve JButton/bug4490179.java
  • e3b2638: 8331959: Update PKCS#11 Cryptographic Token Interface to v3.1
  • 159bd1c: 8339902: Open source couple TextField related tests
  • fb37a91: 8339687: Rearrange reachabilityFence()s in jdk.test.lib.util.ForceGC
  • 71d5c0b: 8338100: C2: assert(!n_loop->is_member(get_loop(lca))) failed: control must not be back in the loop
  • 585297d: 8336498: [macos] [build]: install-file macro may run into permission denied error
  • f706c24: 8333391: Test com/sun/jdi/InterruptHangTest.java failed: Thread was never interrupted during sleep
  • b532a4a: 8336692: Redo fix for JDK-8284620
  • ... and 9 more: https://git.openjdk.org/jdk17u-dev/compare/9c126b3c86860e98b40e3a2a8b576760d80e0389...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 18, 2024
@openjdk openjdk bot closed this Dec 18, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 18, 2024
@openjdk
Copy link

openjdk bot commented Dec 18, 2024

@GoeLin Pushed as commit 7d8dd1b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant