8282590: C2: assert(addp->is_AddP() && addp->outcnt() > 0) failed: Don't process dead nodes

[TheRealMDoerr]

Clean backport of JDK-8282590

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8282590: C2: assert(addp->is_AddP() && addp->outcnt() > 0) failed: Don't process dead nodes

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/315/head:pull/315
$ git checkout pull/315

Update a local copy of the PR:
$ git checkout pull/315
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/315/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 315

View PR using the GUI difftool:
$ git pr show -t 315

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/315.diff

[bridgekeeper]

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282590: C2: assert(addp->is_AddP() && addp->outcnt() > 0) failed: Don't process dead nodes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (d7b2f5f8)

[GoeLin]

What's wrong with the Pre-submit tests?

[TheRealMDoerr]

What's wrong with the Pre-submit tests?

Some "Unpack jdk" jobs have failed. Unrelated to this change.

[TheRealMDoerr]

/integrate

[openjdk]

Going to push as commit 2c79c33.
Since your change was applied there have been 19 commits pushed to the master branch:

• 2aa1fe0: 8283641: Large value for CompileThresholdScaling causes assert
• b9089e7: 8283451: C2: assert(_base == Long) failed: Not a Long
• 8fb8fe6: 8283834: Unmappable character for US-ASCII encoding in TestPredicateInputBelowLoopPredicate
• 52bbd69: 8282592: C2: assert(false) failed: graph should be schedulable
• cdf144e: 8281811: assert(_base == Tuple) failed: Not a Tuple after JDK-8280799
• 7252649: 8280799: С2: assert(false) failed: cyclic dependency prevents range check elimination
• f883f51: 8282312: Minor corrections to evbroadcasti32x4 intrinsic on x86
• 329711d: 8279586: [macos] custom JCheckBox and JRadioBox with custom icon set: focus is still displayed after unchecking
• a1a2992: 8271008: appcds/*/MethodHandlesAsCollectorTest.java tests time out because of excessive GC (CodeCache GC Threshold) in loom
• d66b6e1: 8282874: Bad performance on gather/scatter API caused by different IntSpecies of indexMap
• ... and 9 more: https://git.openjdk.java.net/jdk17u-dev/compare/bf88ff18ad6e6d16b013e0b4caa8cc493fc11b2f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr Pushed as commit 2c79c33.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.