8341424: GHA: Collect hs_errs from build time failures

[vieiro]

Backport of JDK-8341424 and companion JDK-8342704

This collects hs_errs when they happen with GitHub Actions, which may be useful during reviews. The idea is to backport this to 11 too.

Low risk, as this affects GHA actions only. GHA builds and tests run correctly.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8342704 needs maintainer approval
• JDK-8341424 needs maintainer approval

Issues

• JDK-8341424: GHA: Collect hs_errs from build time failures (Enhancement - P4 - Approved)
• JDK-8342704: GHA: Report truncation is broken after JDK-8341424 (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3152/head:pull/3152
$ git checkout pull/3152

Update a local copy of the PR:
$ git checkout pull/3152
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3152/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3152

View PR using the GUI difftool:
$ git pr show -t 3152

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3152.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vieiro This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341424: GHA: Collect hs_errs from build time failures
8342704: GHA: Report truncation is broken after JDK-8341424

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• 247815b: 8325937: runtime/handshake/HandshakeDirectTest.java causes "monitor end should be strictly below the frame pointer" assertion failure on AArch64
• 10ea45e: 8316149: Open source several Swing JTree JViewport KeyboardManager tests
• d9aa705: 8315952: Open source several Swing JToolbar JTooltip JTree tests
• bfc957a: 8344646: The libjsig deprecation warning should go to stderr not stdout
• e34f9ab: 8342541: Exclude List/KeyEventsTest/KeyEventsTest.java from running on macOS
• 21f2c1b: 8342811: java/net/httpclient/PlainProxyConnectionTest.java failed: Unexpected connection count: 5
• 1da0179: 8277240: java/awt/Graphics2D/ScaledTransform/ScaledTransform.java dialog does not get disposed
• c6bcba2: 8342270: Test sun/security/pkcs11/Provider/RequiredMechCheck.java needs write access to src tree
• 7203110: 8333427: langtools/tools/javac/newlines/NewLineTest.java is failing on Japanese Windows
• 33ff519: 8340116: test/jdk/sun/security/tools/jarsigner/PreserveRawManifestEntryAndDigest.java can fail due to regex
• ... and 4 more: https://git.openjdk.org/jdk17u-dev/compare/cdf62864a7991a973a5108b8941f59ec1d6ca0ba...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issues from the original commit.

[openjdk]

⚠️ @vieiro This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (48889121)

[vieiro]

/approval request Let's keep these hs_err files when they are generated. This may prove valuable in the future.

[openjdk]

@vieiro
8341424: The approval request has been created successfully.
8342704: The approval request has been created successfully.

[vieiro]

/integrate

[openjdk]

@vieiro
Your change (at version 4888912) is now ready to be sponsored by a Committer.

[GoeLin]

/integrate

[openjdk]

@GoeLin Only the author (@vieiro) is allowed to issue the integrate command. As this pull request is ready to be sponsored, and you are an eligible sponsor, did you mean to issue the /sponsor command?

[TheRealMDoerr]

/sponsor

[openjdk]

Going to push as commit 3bc06ab.
Since your change was applied there have been 27 commits pushed to the master branch:

• ac22219: 8342609: jpackage test helper function incorrectly removes a directory instead of its contents only
• 6ef13ab: 8339883: Open source several AWT/2D related tests
• 743724e: 8319567: Update java/lang/invoke tests to support vm flags
• a266ca0: 8323196: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Events are not ordered! Reuse = false"
• 5623e10: 8331153: JFR: Improve logging of jdk/jfr/api/consumer/filestream/TestOrdered.java
• e6fb662: 8345414: Google CAInterop test failures
• 8f93d8a: 8342602: Remove JButton/PressedButtonRightClickTest test
• e7fedf5: 8343128: PassFailJFrame.java test result: Error. Bad action for script: build}
• b121ce5: 8328553: Get rid of JApplet in test/jdk/sanity/client/lib/SwingSet2/src/DemoModule.java
• 0b14f53: 8326421: Add jtreg test for large arrayCopy disjoint case.
• ... and 17 more: https://git.openjdk.org/jdk17u-dev/compare/cdf62864a7991a973a5108b8941f59ec1d6ca0ba...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr @vieiro Pushed as commit 3bc06ab.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.