Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283641: Large value for CompileThresholdScaling causes assert #316

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Mar 30, 2022

Clean backport of JDK-8283641


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8283641: Large value for CompileThresholdScaling causes assert

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/316/head:pull/316
$ git checkout pull/316

Update a local copy of the PR:
$ git checkout pull/316
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/316/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 316

View PR using the GUI difftool:
$ git pr show -t 316

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/316.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 30, 2022

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c1048021fe57b78bb1f300b977588e1a93a284b6 8283641: Large value for CompileThresholdScaling causes assert Mar 30, 2022
@openjdk
Copy link

openjdk bot commented Mar 30, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 30, 2022

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283641: Large value for CompileThresholdScaling causes assert

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 30, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 30, 2022

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Mar 31, 2022

What's wrong with the Pre-submit tests?

@TheRealMDoerr
Copy link
Contributor Author

What's wrong with the Pre-submit tests?

"Install cygwin" job has failed. Unrelated to this change.

@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 1, 2022

Going to push as commit 2aa1fe0.
Since your change was applied there have been 18 commits pushed to the master branch:

  • b9089e7: 8283451: C2: assert(_base == Long) failed: Not a Long
  • 8fb8fe6: 8283834: Unmappable character for US-ASCII encoding in TestPredicateInputBelowLoopPredicate
  • 52bbd69: 8282592: C2: assert(false) failed: graph should be schedulable
  • cdf144e: 8281811: assert(_base == Tuple) failed: Not a Tuple after JDK-8280799
  • 7252649: 8280799: С2: assert(false) failed: cyclic dependency prevents range check elimination
  • f883f51: 8282312: Minor corrections to evbroadcasti32x4 intrinsic on x86
  • 329711d: 8279586: [macos] custom JCheckBox and JRadioBox with custom icon set: focus is still displayed after unchecking
  • a1a2992: 8271008: appcds/*/MethodHandlesAsCollectorTest.java tests time out because of excessive GC (CodeCache GC Threshold) in loom
  • d66b6e1: 8282874: Bad performance on gather/scatter API caused by different IntSpecies of indexMap
  • 3c34eb1: 8280901: MethodHandle::linkToNative stub is missing w/ -Xint
  • ... and 8 more: https://git.openjdk.java.net/jdk17u-dev/compare/bf88ff18ad6e6d16b013e0b4caa8cc493fc11b2f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 1, 2022
@openjdk openjdk bot closed this Apr 1, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 1, 2022
@openjdk
Copy link

openjdk bot commented Apr 1, 2022

@TheRealMDoerr Pushed as commit 2aa1fe0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants