Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8282887: Potential memory leak in sun.util.locale.provider.HostLocaleProviderAdapterImpl.getNumberPattern() on Windows #317

Closed

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Mar 30, 2022

A clean and low risk backport to fix a memory leak.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8282887: Potential memory leak in sun.util.locale.provider.HostLocaleProviderAdapterImpl.getNumberPattern() on Windows

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/317/head:pull/317
$ git checkout pull/317

Update a local copy of the PR:
$ git checkout pull/317
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/317/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 317

View PR using the GUI difftool:
$ git pr show -t 317

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/317.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 30, 2022

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2cddf3f5391518ea40796e6c4759047d51b7b312 8282887: Potential memory leak in sun.util.locale.provider.HostLocaleProviderAdapterImpl.getNumberPattern() on Windows Mar 30, 2022
@openjdk
Copy link

openjdk bot commented Mar 30, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 30, 2022

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282887: Potential memory leak in sun.util.locale.provider.HostLocaleProviderAdapterImpl.getNumberPattern() on Windows

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • bf88ff1: 8280600: C2: assert(!had_error) failed: bad dominance
  • 02292c5: 8271055: Crash during deoptimization with "assert(bb->is_reachable()) failed: getting result from unreachable basicblock" with -XX:+VerifyStack
  • 76402bc: 8280964: [Linux aarch64] : drawImage dithers TYPE_BYTE_INDEXED images incorrectly
  • 2f39462: 8272358: Some tests may fail when executed with other locales than the US
  • a9c2a50: 8277055: Assert "missing inlining msg" with -XX:+PrintIntrinsics
  • 0200d64: 8264605: vmTestbase/nsk/jvmti/SuspendThread/suspendthrd003/TestDescription.java failed with "agent_tools.cpp, 471: (foundThread = (jthread) jni_env->NewGlobalRef(foundThread)) != NULL"
  • 373526a: 8279219: [REDO] C2 crash when allocating array of size too large
  • 6eaf579: 8281544: assert(VM_Version::supports_avx512bw()) failed for Tests jdk/incubator/vector/
  • 9068185: 8283350: (tz) Update Timezone Data to 2022a
  • b46fabf: 8275337: C1: assert(false) failed: live_in set of first block must be empty
  • ... and 2 more: https://git.openjdk.java.net/jdk17u-dev/compare/7e41d8439305a9966d968c51480df1623c50cbb2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 30, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 30, 2022

Webrevs

@zhengyu123
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 3, 2022

Going to push as commit e8db346.
Since your change was applied there have been 40 commits pushed to the master branch:

  • ac41711: 8282628: Potential memory leak in sun.font.FontConfigManager.getFontConfig()
  • ab2f61e: 8283497: [windows] print TMP and TEMP in hs_err and VM.info
  • 06c955a: 8283249: CompressedClassPointers.java fails on ppc with 'Narrow klass shift: 0' missing
  • 25f2a52: 8281450: Remove unnecessary operator new and delete from ObjectMonitor
  • 1007ded: 8280941: os::print_memory_mappings() prints segment preceeding the inclusion range
  • 0bb751b: 8280004: DCmdArgument::parse_value() should handle NULL input
  • 2875e18: 8273142: Remove dependancy of TestHttpServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/http/ tests
  • 6976bb4: 8256368: Avoid repeated upcalls into Java to re-resolve MH/VH linkers/invokers
  • 2c79c33: 8282590: C2: assert(addp->is_AddP() && addp->outcnt() > 0) failed: Don't process dead nodes
  • 2aa1fe0: 8283641: Large value for CompileThresholdScaling causes assert
  • ... and 30 more: https://git.openjdk.java.net/jdk17u-dev/compare/7e41d8439305a9966d968c51480df1623c50cbb2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 3, 2022
@openjdk openjdk bot closed this Apr 3, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 3, 2022
@openjdk
Copy link

openjdk bot commented Apr 3, 2022

@zhengyu123 Pushed as commit e8db346.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant