8346887: DrawFocusRect() may cause an assertion failure

[satyenme]

Backporting JDK-8346887: DrawFocusRect() may cause an assertion failure. Minor change that adds an additional check before running an assertion for windows. Ran GHA Sanity Checks and local Tier 1 and Tier 2 tests. Patch is clean.

---

Progress

• Change must not contain extraneous whitespace
• JDK-8346887 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8346887: DrawFocusRect() may cause an assertion failure (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3199/head:pull/3199
$ git checkout pull/3199

Update a local copy of the PR:
$ git checkout pull/3199
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3199/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3199

View PR using the GUI difftool:
$ git pr show -t 3199

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3199.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@satyenme This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346887: DrawFocusRect() may cause an assertion failure

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

• 72bddde: 8342508: Use latch in BasicMenuUI/bug4983388.java instead of delay
• 032d1ae: 8342498: Add test for Allocation elimination after use as alignment reference by SuperWord
• 77ce004: 8333403: Write a test to check various components events are triggered properly
• 19345ad: 8340687: Open source closed frame tests 8278822: Bump update version for OpenJDK: jdk-17.0.3 #1
• eede9d3: 8324807: Manual printer tests have no Pass/Fail buttons, instructions close set 2
• 88c1aa2: 8325529: Remove unused imports from ModuleGenerator test file
• 8920296: 8328819: Remove applet usage from JFileChooser tests bug6698013
• 24c1243: 8312416: Tests in Locale should have more descriptive names
• 0246696: 8305853: java/text/Format/DateFormat/DateFormatRegression.java fails with "Uncaught exception thrown in test method Test4089106"
• dffe2dc: 8276202: LogFileOutput.invalid_file_vm asserts when being executed from a read only working directory
• ... and 15 more: https://git.openjdk.org/jdk17u-dev/compare/53d7539a889cbcfffa8524fd9e47efdf5c121d87...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[satyenme]

/approval request for backport. Minor change that adds an additional check before an assertion for windows. Tested with tier1, tier2, and GHA tests. Risk is low.

[openjdk]

@satyenme
8346887: The approval request has been created successfully.

[mlbridge]

Webrevs

• 00: Full (568b9b15)

[GoeLin]

Hi satyenme
Do you have any indication that tier1 or tier2 cover this code?

[satyenme]

/integrate

[openjdk]

@satyenme
Your change (at version 568b9b1) is now ready to be sponsored by a Committer.

[satyenme]

Hi satyenme Do you have any indication that tier1 or tier2 cover this code?

From my understanding the changes aren't directly covered by the jtreg tier1 or tier2 tests. I've tested running with JCK tests (mentioned on the original issue), and they're passing.

[phohensee]

/sponsor

[openjdk]

Going to push as commit df6014e.
Since your change was applied there have been 25 commits pushed to the master branch:

• 72bddde: 8342508: Use latch in BasicMenuUI/bug4983388.java instead of delay
• 032d1ae: 8342498: Add test for Allocation elimination after use as alignment reference by SuperWord
• 77ce004: 8333403: Write a test to check various components events are triggered properly
• 19345ad: 8340687: Open source closed frame tests 8278822: Bump update version for OpenJDK: jdk-17.0.3 #1
• eede9d3: 8324807: Manual printer tests have no Pass/Fail buttons, instructions close set 2
• 88c1aa2: 8325529: Remove unused imports from ModuleGenerator test file
• 8920296: 8328819: Remove applet usage from JFileChooser tests bug6698013
• 24c1243: 8312416: Tests in Locale should have more descriptive names
• 0246696: 8305853: java/text/Format/DateFormat/DateFormatRegression.java fails with "Uncaught exception thrown in test method Test4089106"
• dffe2dc: 8276202: LogFileOutput.invalid_file_vm asserts when being executed from a read only working directory
• ... and 15 more: https://git.openjdk.org/jdk17u-dev/compare/53d7539a889cbcfffa8524fd9e47efdf5c121d87...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @satyenme Pushed as commit df6014e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.