Skip to content

8343599: Kmem limit and max values swapped when printing container information #3227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

RadekCap
Copy link
Contributor

@RadekCap RadekCap commented Jan 17, 2025

Backport of JDK-8343599 Kmem limit and max values swapped when printing container information

Clean backport.
Passed tier1 tests.
Passed gtests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8343599 needs maintainer approval

Issue

  • JDK-8343599: Kmem limit and max values swapped when printing container information (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3227/head:pull/3227
$ git checkout pull/3227

Update a local copy of the PR:
$ git checkout pull/3227
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3227/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3227

View PR using the GUI difftool:
$ git pr show -t 3227

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3227.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 17, 2025

👋 Welcome back RadekCap! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 17, 2025

@RadekCap This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343599: Kmem limit and max values swapped when printing container information

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

  • c19a7ec: 8321818: vmTestbase/nsk/stress/strace/strace015.java failed with 'Cannot read the array length because "" is null'
  • c293c1f: 8345375: Improve debuggability of test/jdk/java/net/Socket/CloseAvailable.java
  • 7b07a2c: 8343118: [TESTBUG] java/awt/PrintJob/PrintCheckboxTest/PrintCheckboxManualTest.java fails with rror. Can't find HTML file PrintCheckboxManualTest.html
  • 683a626: 8341111: open source several AWT tests including menu shortcut tests
  • c61d62b: 8341037: Use standard layouts in DefaultFrameIconTest.java and MenuCrash.java
  • 57e792a: 8334305: Remove all code for nsk.share.Log verbose mode
  • ba71fc0: 8325659: Normalize Random usage by incubator vector tests
  • a1acef7: 8329320: Simplify awt/print/PageFormat/NullPaper.java test
  • 405eec8: 8270961: [TESTBUG] Move GotWrongOOMEException into vm.share.gc package
  • e06115c: Merge
  • ... and 25 more: https://git.openjdk.org/jdk17u-dev/compare/df6014ef96bf90ac738fff87bafe30167eaea365...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 6cdebf0e4ce274fcaaff0bad292d467e31d698d8 8343599: Kmem limit and max values swapped when printing container information Jan 17, 2025
@openjdk
Copy link

openjdk bot commented Jan 17, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 17, 2025

⚠️ @RadekCap This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 17, 2025
@RadekCap
Copy link
Contributor Author

/approval request Kmem limit and max values swapped when printing container information

@mlbridge
Copy link

mlbridge bot commented Jan 17, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 17, 2025

@RadekCap
8343599: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jan 17, 2025
@RealCLanger
Copy link
Contributor

@RadekCap A backport to jdk21u is missing and should be done first. Removing the jdk17u-fix-request label for now until backport to jdk21 updates has been done.

@openjdk openjdk bot removed the approval label Jan 18, 2025
@RadekCap
Copy link
Contributor Author

@RealCLanger Ah, I've overlooked it probably, will do. Thanks!

@RadekCap
Copy link
Contributor Author

Added a backport for jdk21u-dev - openjdk/jdk21u-dev#1341

@RadekCap
Copy link
Contributor Author

21u-dev change has been integrated so we can continue here.

@jerboaa
Copy link
Contributor

jerboaa commented Jan 27, 2025

@RadekCap You need to re-apply the approval label (e.g. using /approval request ...)

@RadekCap
Copy link
Contributor Author

/approval request Kmem limit and max values swapped when printing container information

@openjdk
Copy link

openjdk bot commented Jan 27, 2025

@RadekCap
8343599: The approval request was already up to date.

@openjdk openjdk bot added the approval label Jan 27, 2025
@openjdk
Copy link

openjdk bot commented Jan 28, 2025

⚠️ @RadekCap the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout JDK-8343599
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 28, 2025
@RadekCap
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 28, 2025
@openjdk
Copy link

openjdk bot commented Jan 28, 2025

@RadekCap
Your change (at version 808466b) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented Jan 28, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 28, 2025

Going to push as commit 95d8c06.
Since your change was applied there have been 35 commits pushed to the master branch:

  • c19a7ec: 8321818: vmTestbase/nsk/stress/strace/strace015.java failed with 'Cannot read the array length because "" is null'
  • c293c1f: 8345375: Improve debuggability of test/jdk/java/net/Socket/CloseAvailable.java
  • 7b07a2c: 8343118: [TESTBUG] java/awt/PrintJob/PrintCheckboxTest/PrintCheckboxManualTest.java fails with rror. Can't find HTML file PrintCheckboxManualTest.html
  • 683a626: 8341111: open source several AWT tests including menu shortcut tests
  • c61d62b: 8341037: Use standard layouts in DefaultFrameIconTest.java and MenuCrash.java
  • 57e792a: 8334305: Remove all code for nsk.share.Log verbose mode
  • ba71fc0: 8325659: Normalize Random usage by incubator vector tests
  • a1acef7: 8329320: Simplify awt/print/PageFormat/NullPaper.java test
  • 405eec8: 8270961: [TESTBUG] Move GotWrongOOMEException into vm.share.gc package
  • e06115c: Merge
  • ... and 25 more: https://git.openjdk.org/jdk17u-dev/compare/df6014ef96bf90ac738fff87bafe30167eaea365...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 28, 2025
@openjdk openjdk bot closed this Jan 28, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 28, 2025
@openjdk
Copy link

openjdk bot commented Jan 28, 2025

@jerboaa @RadekCap Pushed as commit 95d8c06.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants