-
Notifications
You must be signed in to change notification settings - Fork 224
8343599: Kmem limit and max values swapped when printing container information #3227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back RadekCap! A progress list of the required criteria for merging this PR into |
@RadekCap This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 35 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Kmem limit and max values swapped when printing container information |
Webrevs
|
@RadekCap A backport to jdk21u is missing and should be done first. Removing the jdk17u-fix-request label for now until backport to jdk21 updates has been done. |
@RealCLanger Ah, I've overlooked it probably, will do. Thanks! |
Added a backport for jdk21u-dev - openjdk/jdk21u-dev#1341 |
21u-dev change has been integrated so we can continue here. |
@RadekCap You need to re-apply the approval label (e.g. using |
/approval request Kmem limit and max values swapped when printing container information |
|
/integrate |
/sponsor |
Going to push as commit 95d8c06.
Your commit was automatically rebased without conflicts. |
Backport of JDK-8343599 Kmem limit and max values swapped when printing container information
Clean backport.
Passed tier1 tests.
Passed gtests.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3227/head:pull/3227
$ git checkout pull/3227
Update a local copy of the PR:
$ git checkout pull/3227
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3227/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3227
View PR using the GUI difftool:
$ git pr show -t 3227
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3227.diff
Using Webrev
Link to Webrev Comment