Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 30, 2025

I backport this because we see reported problems on our Windows Server 2025 box.

Resolved because StaticProperty has no osName() in 17.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8345368 needs maintainer approval

Issue

  • JDK-8345368: java/io/File/createTempFile/SpecialTempFile.java fails on Windows Server 2025 (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3258/head:pull/3258
$ git checkout pull/3258

Update a local copy of the PR:
$ git checkout pull/3258
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3258/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3258

View PR using the GUI difftool:
$ git pr show -t 3258

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3258.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 30, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 30, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345368: java/io/File/createTempFile/SpecialTempFile.java fails on Windows Server 2025

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • 7213c0d: 8340411: open source several 2D imaging tests
  • 751130a: 8345468: test/jdk/javax/swing/JScrollBar/4865918/bug4865918.java fails in ubuntu22.04
  • 50c6fab: 8330702: Update failure handler to don't generate Error message if cores actions are empty
  • cf4fca2: 8266435: WBMPImageReader.read() should not truncate the input stream
  • bd41268: 8338571: [TestBug] DefaultCloseOperation.java test not working as expected wrt instruction after JDK-8325851 fix
  • 52a25fd: 8343491: javax/management/remote/mandatory/connection/DeadLockTest.java failing with NoSuchObjectException: no such object in table
  • 373b67c: 8226938: [TEST_BUG]GTK L&F: There is no Details button in FileChooser Dialog
  • f0527c1: 8340078: Open source several 2D tests
  • 2ebb6f5: 8332917: failure_handler should execute gdb "info threads" command on linux
  • 3c6af86: 8329692: Add more details to FrameStateTest.java test instructions
  • ... and 5 more: https://git.openjdk.org/jdk17u-dev/compare/b0c130ba3aa443ca58e9bcda813a80e989632b93...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport b0c131e872f997cb7deadc9b0a87bd76e3a2a83c 8345368: java/io/File/createTempFile/SpecialTempFile.java fails on Windows Server 2025 Jan 30, 2025
@openjdk
Copy link

openjdk bot commented Jan 30, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Jan 30, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 30, 2025

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jan 31, 2025

GHA failure: three times wget issue, unrelated.

Copy link
Member

@MBaesken MBaesken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks okay.

Btw. a comment about the check or an utility function isWindows11() / isWindows2025() would be much better but that's not in scope of the backport.

@openjdk
Copy link

openjdk bot commented Jan 31, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jan 31, 2025
@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Feb 11, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Feb 11, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Feb 11, 2025

Going to push as commit 2691c14.
Since your change was applied there have been 17 commits pushed to the master branch:

  • f63ee83: 8346671: java/nio/file/Files/probeContentType/Basic.java fails on Windows 2025
  • 087e8a2: 8342988: GHA: Build JTReg in single step
  • 7213c0d: 8340411: open source several 2D imaging tests
  • 751130a: 8345468: test/jdk/javax/swing/JScrollBar/4865918/bug4865918.java fails in ubuntu22.04
  • 50c6fab: 8330702: Update failure handler to don't generate Error message if cores actions are empty
  • cf4fca2: 8266435: WBMPImageReader.read() should not truncate the input stream
  • bd41268: 8338571: [TestBug] DefaultCloseOperation.java test not working as expected wrt instruction after JDK-8325851 fix
  • 52a25fd: 8343491: javax/management/remote/mandatory/connection/DeadLockTest.java failing with NoSuchObjectException: no such object in table
  • 373b67c: 8226938: [TEST_BUG]GTK L&F: There is no Details button in FileChooser Dialog
  • f0527c1: 8340078: Open source several 2D tests
  • ... and 7 more: https://git.openjdk.org/jdk17u-dev/compare/b0c130ba3aa443ca58e9bcda813a80e989632b93...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 11, 2025
@openjdk openjdk bot closed this Feb 11, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 11, 2025
@openjdk
Copy link

openjdk bot commented Feb 11, 2025

@GoeLin Pushed as commit 2691c14.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8345368 branch February 11, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants