-
Notifications
You must be signed in to change notification settings - Fork 232
8342988: GHA: Build JTReg in single step #3264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
|
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
jerboaa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for doing this!
|
|
|
/integrate |
|
Going to push as commit 087e8a2.
Your commit was automatically rebased without conflicts. |
I want to backport this to reduce errors in gha runs. The backport is based on the commit to 21.
I had to resolve becasue 8297984: Turn on warnings as errors for javadoc
is not in 17.
Omitted the edits in the code added by JDK-8297984.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3264/head:pull/3264$ git checkout pull/3264Update a local copy of the PR:
$ git checkout pull/3264$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3264/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3264View PR using the GUI difftool:
$ git pr show -t 3264Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3264.diff
Using Webrev
Link to Webrev Comment