Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Feb 20, 2025

I backport this for parity with 17.0.16-oracle.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8348675 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8348675: TrayIcon tests fail in Ubuntu 24.10 Wayland (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3289/head:pull/3289
$ git checkout pull/3289

Update a local copy of the PR:
$ git checkout pull/3289
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3289/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3289

View PR using the GUI difftool:
$ git pr show -t 3289

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3289.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 20, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 20, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8348675: TrayIcon tests fail in Ubuntu 24.10 Wayland

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 6f4fc82149b52dd91289fe42def7d1cacad31212 8348675: TrayIcon tests fail in Ubuntu 24.10 Wayland Feb 20, 2025
@openjdk
Copy link

openjdk bot commented Feb 20, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Feb 20, 2025
@openjdk
Copy link

openjdk bot commented Feb 20, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 20, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 20, 2025

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Feb 21, 2025

GHA failures: The job was not started because recent account payments have failed or your spending limit needs to be increased. Please check the 'Billing & plans' section in your settings.
Unrelated.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Feb 21, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Feb 25, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Feb 25, 2025

Going to push as commit 117ce56.
Since your change was applied there have been 13 commits pushed to the master branch:

  • 4216ad6: 8344581: [TESTBUG] java/awt/Robot/ScreenCaptureRobotTest.java failing on macOS
  • 16b2146: 8339356: Test javax/net/ssl/SSLSocket/Tls13PacketSize.java failed with java.net.SocketException: An established connection was aborted by the software in your host machine
  • db37be3: 8342635: javax/swing/JFileChooser/FileSystemView/WindowsDefaultIconSizeTest.java creates tmp file in src dir
  • bb391d7: 8327476: Upgrade JLine to 3.26.1
  • fbf5ebe: 8198666: Many java/awt/Modal/OnTop/ test fails on mac
  • 01d107a: 8339728: [Accessibility,Windows,JAWS] Bug in the getKeyChar method of the AccessBridge class
  • 2846c9e: 8346828: javax/swing/JScrollBar/4865918/bug4865918.java still fails in CI
  • 715d37e: 8346324: javax/swing/JScrollBar/4865918/bug4865918.java fails in CI
  • 9f48d42: 8338595: Add more linesize for MIME decoder in macro bench test Base64Decode
  • f7a071e: 8337222: gc/TestDisableExplicitGC.java fails due to unexpected CodeCache GC
  • ... and 3 more: https://git.openjdk.org/jdk17u-dev/compare/b2f814e033e1bd81be1d8c2dff16dcf7aa80eddc...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 25, 2025
@openjdk openjdk bot closed this Feb 25, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 25, 2025
@openjdk
Copy link

openjdk bot commented Feb 25, 2025

@GoeLin Pushed as commit 117ce56.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant