Skip to content

8340560: Open Source several AWT/2D font and rendering tests#3303

Closed
GoeLin wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-GoeLin-ade17ecb-master
Closed

8340560: Open Source several AWT/2D font and rendering tests#3303
GoeLin wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-GoeLin-ade17ecb-master

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Feb 27, 2025

I backport this for parity with 17.0.15-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8340560 needs maintainer approval

Issue

  • JDK-8340560: Open Source several AWT/2D font and rendering tests (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3303/head:pull/3303
$ git checkout pull/3303

Update a local copy of the PR:
$ git checkout pull/3303
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3303/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3303

View PR using the GUI difftool:
$ git pr show -t 3303

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3303.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 27, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 27, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340560: Open Source several AWT/2D font and rendering tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 72e9063: 8343205: CompileBroker::possibly_add_compiler_threads excessively polls available memory
  • e45b98b: 8347629: Test FailOverDirectExecutionControlTest.java fails with -Xcomp

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport ade17ecb6cb5125d048401a878b557e5afefc08c 8340560: Open Source several AWT/2D font and rendering tests Feb 27, 2025
@openjdk
Copy link

openjdk bot commented Feb 27, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Feb 27, 2025
@openjdk
Copy link

openjdk bot commented Feb 27, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 27, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 27, 2025

Webrevs

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Mar 3, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Mar 10, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Mar 10, 2025

Going to push as commit 1b1c92e.
Since your change was applied there have been 19 commits pushed to the master branch:

  • 8dec85c: 8325435: [macos] Menu or JPopupMenu not closed when main window is resized
  • 574e1ad: 8316497: ColorConvertOp - typo for non-ICC conversions needs one-line fix
  • 4582029: 8077371: Binary files in JAXP test should be removed
  • 2354a02: 8315876: Open source several Swing CSS related tests
  • 0935405: 8218474: JComboBox display issue with GTKLookAndFeel
  • 4c12437: 8298147: Clang warns about pointless comparisons
  • 04a1b0d: 8297173: usageTicks and totalTicks should be volatile to ensure that different threads get the latest ticks
  • 4f1eb59: 8296072: CertAttrSet::encode and DerEncoder::derEncode should write into DerOutputStream
  • db834e0: 5074006: Swing JOptionPane shows tag as a string after newline
  • f00607a: 8282863: java/awt/FullScreen/FullscreenWindowProps/FullscreenWindowProps.java fails on Windows 10 with HiDPI screen
  • ... and 9 more: https://git.openjdk.org/jdk17u-dev/compare/fd353e38a820eed00b1a5f28e892a4d6baa3f1d1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 10, 2025
@openjdk openjdk bot closed this Mar 10, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 10, 2025
@openjdk
Copy link

openjdk bot commented Mar 10, 2025

@GoeLin Pushed as commit 1b1c92e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant