8309841: Jarsigner should print a warning if an entry is removed

[wkia]

This is backport of "8309841: Jarsigner should print a warning if an entry is removed"

Original patch does not apply cleanly to jdk17, some minor conflicts, and _ was replaced with a variable in test/jdk/sun/security/tools/jarsigner/RemovedFiles.java.

We need this fix in jdk17 and below, down to jdk8, as all versions have this issue with jarsigner.

New tests successfully ran locally on Linux, x86_64.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change requires CSR request JDK-8334261 to be approved
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8309841 needs maintainer approval

Issues

• JDK-8309841: Jarsigner should print a warning if an entry is removed (Enhancement - P3 - Approved)
• JDK-8334261: Jarsigner should print a warning if an entry is removed (CSR)

Reviewers

• Yuri Nesterenko (@yan-too - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3310/head:pull/3310
$ git checkout pull/3310

Update a local copy of the PR:
$ git checkout pull/3310
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3310/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3310

View PR using the GUI difftool:
$ git pr show -t 3310

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3310.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@wkia This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309841: Jarsigner should print a warning if an entry is removed

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

• 03828f8: 8350616: Skip ValidateHazardPtrsClosure in non-debug builds
• 682c939: 8348596: Update FreeType to 2.13.3
• cf54b0d: 8347126: gc/stress/TestStressG1Uncommit.java gets OOM-killed
• d215a1f: 8348936: [Accessibility,macOS,VoiceOver] VoiceOver doesn't announce untick on toggling the checkbox with "space" key on macOS
• a682f8d: 8349751: AIX build failure after upgrade pipewire to 1.3.81
• 0048246: 8348600: Update PipeWire to 1.3.81
• 8da895b: 8348299: Update List/ItemEventTest/ItemEventTest.java
• 11f91c3: 8347911: Limit the length of inflated text chunks
• 6288b3d: 8341535: sun/awt/font/TestDevTransform.java fails with RuntimeException: Different rendering
• f91d7d3: 8341170: Open source several Choice related tests (part 2)
• ... and 20 more: https://git.openjdk.org/jdk17u-dev/compare/fd353e38a820eed00b1a5f28e892a4d6baa3f1d1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@yan-too) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (0e14bbf3)

[openjdk]

⚠️ @wkia This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[wkia]

/approval request I'd like to backport this to 17u-dev. We need this fix in jdk17 and below, down to jdk8, as all versions have this issue with jarsigner. Original patch does not apply cleanly to jdk17, some minor conflicts resolved. New tests successfully ran locally on Linux, x86_64.

[openjdk]

@wkia
8309841: The approval request has been created successfully.

[wkia]

/integrate

[openjdk]

@wkia
Your change (at version 0e14bbf) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit f39ce94.
Since your change was applied there have been 30 commits pushed to the master branch:

• 03828f8: 8350616: Skip ValidateHazardPtrsClosure in non-debug builds
• 682c939: 8348596: Update FreeType to 2.13.3
• cf54b0d: 8347126: gc/stress/TestStressG1Uncommit.java gets OOM-killed
• d215a1f: 8348936: [Accessibility,macOS,VoiceOver] VoiceOver doesn't announce untick on toggling the checkbox with "space" key on macOS
• a682f8d: 8349751: AIX build failure after upgrade pipewire to 1.3.81
• 0048246: 8348600: Update PipeWire to 1.3.81
• 8da895b: 8348299: Update List/ItemEventTest/ItemEventTest.java
• 11f91c3: 8347911: Limit the length of inflated text chunks
• 6288b3d: 8341535: sun/awt/font/TestDevTransform.java fails with RuntimeException: Different rendering
• f91d7d3: 8341170: Open source several Choice related tests (part 2)
• ... and 20 more: https://git.openjdk.org/jdk17u-dev/compare/fd353e38a820eed00b1a5f28e892a4d6baa3f1d1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @wkia Pushed as commit f39ce94.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.