Skip to content

8290162: Reset recursion counter missed in fix of JDK-8224267 #3315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 3, 2025

I backport this for parity with 17.0.16-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8290162 needs maintainer approval

Issue

  • JDK-8290162: Reset recursion counter missed in fix of JDK-8224267 (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3315/head:pull/3315
$ git checkout pull/3315

Update a local copy of the PR:
$ git checkout pull/3315
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3315/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3315

View PR using the GUI difftool:
$ git pr show -t 3315

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3315.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 3, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 3, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290162: Reset recursion counter missed in fix of JDK-8224267

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@GoeLin GoeLin changed the base branch from master to pr/3314 March 3, 2025 20:51
@GoeLin GoeLin changed the title Goetz backport 8290162 Backport 6e18883d8ffd9a7b7d495da05e9859dc1d1a2677 Mar 3, 2025
@openjdk openjdk bot changed the title Backport 6e18883d8ffd9a7b7d495da05e9859dc1d1a2677 8290162: Reset recursion counter missed in fix of JDK-8224267 Mar 3, 2025
@openjdk
Copy link

openjdk bot commented Mar 3, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Mar 3, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 3, 2025

Webrevs

@openjdk openjdk bot added approval and removed approval labels Mar 4, 2025
@openjdk-notifier openjdk-notifier bot changed the base branch from pr/3314 to master March 4, 2025 15:19
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout goetz_backport_8290162
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@GoeLin
Copy link
Member Author

GoeLin commented Mar 4, 2025

GHA failure: download of MSYS2 failed three times. Unrelated.

@openjdk openjdk bot removed the clean label Mar 4, 2025
@openjdk openjdk bot added clean ready Pull request is ready to be integrated labels Mar 4, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Mar 4, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Mar 4, 2025

Going to push as commit 693c56d.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 4, 2025
@openjdk openjdk bot closed this Mar 4, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 4, 2025
@openjdk
Copy link

openjdk bot commented Mar 4, 2025

@GoeLin Pushed as commit 693c56d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8290162 branch March 4, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant