New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8281522: Rename ADLC classes which have the same name as hotspot variants #332
Conversation
|
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense. It's always good to be able to distinguish the ADLC stuff from the rest.
@tstuefe This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the
|
Thanks Martin! |
/clean |
@tstuefe This backport pull request is now marked as clean |
Note that this PR is still draft! |
/integrate |
I'd like to bring this into JDK17. Its a purely mechanical renaming of classes in ADLC. It does not apply cleanly, but the only conflicts were copyright headers (ADLC gets touched very rarely).
The reason I want this downported is to make future code changes easier and to simplify development. I was on the fence about this one, but since its really low risk, I think it makes sense to downport this.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/332/head:pull/332
$ git checkout pull/332
Update a local copy of the PR:
$ git checkout pull/332
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/332/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 332
View PR using the GUI difftool:
$ git pr show -t 332
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/332.diff