Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 4, 2025

I think this is a good fix to have in 17.
The tests pass, the new one reproduces the error without the fix.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8218474 needs maintainer approval

Issue

  • JDK-8218474: JComboBox display issue with GTKLookAndFeel (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3324/head:pull/3324
$ git checkout pull/3324

Update a local copy of the PR:
$ git checkout pull/3324
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3324/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3324

View PR using the GUI difftool:
$ git pr show -t 3324

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3324.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 4, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 4, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8218474: JComboBox display issue with GTKLookAndFeel

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 2633ee3: 8334560: [PPC64]: postalloc_expand_java_dynamic_call_sched does not copy all fields
  • 6e37df1: 8349200: [JMH] time.format.ZonedDateTimeFormatterBenchmark fails

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport c4449224bbb70d1a0256ebf19297450ab0f98d4b 8218474: JComboBox display issue with GTKLookAndFeel Mar 4, 2025
@openjdk
Copy link

openjdk bot commented Mar 4, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Mar 4, 2025
@GoeLin GoeLin marked this pull request as ready for review March 6, 2025 07:40
@openjdk openjdk bot added approval Requires approval; will be removed when approval is received rfr Pull request is ready for review labels Mar 6, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 6, 2025

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Mar 10, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Mar 10, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Mar 10, 2025

Going to push as commit 0935405.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 4c12437: 8298147: Clang warns about pointless comparisons
  • 04a1b0d: 8297173: usageTicks and totalTicks should be volatile to ensure that different threads get the latest ticks
  • 4f1eb59: 8296072: CertAttrSet::encode and DerEncoder::derEncode should write into DerOutputStream
  • db834e0: 5074006: Swing JOptionPane shows tag as a string after newline
  • f00607a: 8282863: java/awt/FullScreen/FullscreenWindowProps/FullscreenWindowProps.java fails on Windows 10 with HiDPI screen
  • 2633ee3: 8334560: [PPC64]: postalloc_expand_java_dynamic_call_sched does not copy all fields
  • 6e37df1: 8349200: [JMH] time.format.ZonedDateTimeFormatterBenchmark fails

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 10, 2025
@openjdk openjdk bot closed this Mar 10, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 10, 2025
@openjdk
Copy link

openjdk bot commented Mar 10, 2025

@GoeLin Pushed as commit 0935405.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8218474 branch March 10, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant