Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283187: C2: loop candidate for superword not always unrolled fully if superword fails #333

Closed

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Apr 1, 2022

Backport of JDK-8283187
I had to insert the new line in IRNode.java manually, but Skara recognizes it as clean backport.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8283187: C2: loop candidate for superword not always unrolled fully if superword fails

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/333/head:pull/333
$ git checkout pull/333

Update a local copy of the PR:
$ git checkout pull/333
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/333/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 333

View PR using the GUI difftool:
$ git pr show -t 333

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/333.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 1, 2022

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 14c20bc0e0ee32b82ffe653ae9e4a0be52d578cb 8283187: C2: loop candidate for superword not always unrolled fully if superword fails Apr 1, 2022
@openjdk
Copy link

openjdk bot commented Apr 1, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 1, 2022

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283187: C2: loop candidate for superword not always unrolled fully if superword fails

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 1, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 1, 2022

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 5, 2022

Going to push as commit b5e8388.
Since your change was applied there have been 12 commits pushed to the master branch:

  • c923449: 8281822: Test failures on non-DTrace builds due to incomplete DTrace* flags handling
  • efabf45: 8280940: gtest os.release_multi_mappings_vm is racy
  • 83dba03: 8281522: Rename ADLC classes which have the same name as hotspot variants
  • ba4e609: 8282382: Report glibc malloc tunables in error reports
  • bf6b1d9: 8274939: Incorrect size of the pixel storage is used by the robot on macOS
  • e8db346: 8282887: Potential memory leak in sun.util.locale.provider.HostLocaleProviderAdapterImpl.getNumberPattern() on Windows
  • ac41711: 8282628: Potential memory leak in sun.font.FontConfigManager.getFontConfig()
  • ab2f61e: 8283497: [windows] print TMP and TEMP in hs_err and VM.info
  • 06c955a: 8283249: CompressedClassPointers.java fails on ppc with 'Narrow klass shift: 0' missing
  • 25f2a52: 8281450: Remove unnecessary operator new and delete from ObjectMonitor
  • ... and 2 more: https://git.openjdk.java.net/jdk17u-dev/compare/2875e18190957bb49e5f7ec275fba68119e5f096...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 5, 2022
@openjdk openjdk bot closed this Apr 5, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 5, 2022
@openjdk
Copy link

openjdk bot commented Apr 5, 2022

@TheRealMDoerr Pushed as commit b5e8388.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8283187_C2_loop_unrolling branch April 5, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant