New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8279822: CI: Constant pool entries in error state are not supported #334
8279822: CI: Constant pool entries in error state are not supported #334
Conversation
|
This backport pull request has now been updated with issue from the original commit. |
Please add the label again if the change is ready. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pre-submit failure: missing cygwin, unrelated |
@TheRealMDoerr This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 17 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
Thanks for the review! |
/integrate |
Going to push as commit da9aa23.
Your commit was automatically rebased without conflicts. |
@TheRealMDoerr Pushed as commit da9aa23. |
Backport of JDK-8279822
Applies cleanly but I had to set the class file version of the test to
V17
.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/334/head:pull/334
$ git checkout pull/334
Update a local copy of the PR:
$ git checkout pull/334
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/334/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 334
View PR using the GUI difftool:
$ git pr show -t 334
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/334.diff