Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8279822: CI: Constant pool entries in error state are not supported #334

Closed

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Apr 1, 2022

Backport of JDK-8279822
Applies cleanly but I had to set the class file version of the test to V17.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8279822: CI: Constant pool entries in error state are not supported

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/334/head:pull/334
$ git checkout pull/334

Update a local copy of the PR:
$ git checkout pull/334
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/334/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 334

View PR using the GUI difftool:
$ git pr show -t 334

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/334.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 1, 2022

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c5c8c0644d9442846de15422285fffeb91c3e0a1 8279822: CI: Constant pool entries in error state are not supported Apr 1, 2022
@openjdk
Copy link

openjdk bot commented Apr 1, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Apr 1, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 1, 2022

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Apr 8, 2022

Please add the label again if the change is ready. Thanks.

Copy link
Member

@GoeLin GoeLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GoeLin
Copy link
Member

GoeLin commented Apr 8, 2022

Pre-submit failure: missing cygwin, unrelated

@openjdk
Copy link

openjdk bot commented Apr 8, 2022

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279822: CI: Constant pool entries in error state are not supported

Reviewed-by: goetz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • fcc1cc6: 8276880: Remove java/lang/RuntimeTests/exec/ExecWithDir as unnecessary
  • d218ce4: 8284369: TestFailedAllocationBadGraph fails with -XX:TieredStopAtLevel < 4
  • 7d3a528: 8283279: [Testbug] Improve TestGetSwapSpaceSize
  • e78f47e: 8283347: [macos] Bad JNI lookup accessibilityHitTest is shown when Screen magnifier is enabled
  • b5e8388: 8283187: C2: loop candidate for superword not always unrolled fully if superword fails
  • c923449: 8281822: Test failures on non-DTrace builds due to incomplete DTrace* flags handling
  • efabf45: 8280940: gtest os.release_multi_mappings_vm is racy
  • 83dba03: 8281522: Rename ADLC classes which have the same name as hotspot variants
  • ba4e609: 8282382: Report glibc malloc tunables in error reports
  • bf6b1d9: 8274939: Incorrect size of the pixel storage is used by the robot on macOS
  • ... and 7 more: https://git.openjdk.java.net/jdk17u-dev/compare/2875e18190957bb49e5f7ec275fba68119e5f096...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 8, 2022
@TheRealMDoerr
Copy link
Contributor Author

Thanks for the review!

@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 8, 2022

Going to push as commit da9aa23.
Since your change was applied there have been 17 commits pushed to the master branch:

  • fcc1cc6: 8276880: Remove java/lang/RuntimeTests/exec/ExecWithDir as unnecessary
  • d218ce4: 8284369: TestFailedAllocationBadGraph fails with -XX:TieredStopAtLevel < 4
  • 7d3a528: 8283279: [Testbug] Improve TestGetSwapSpaceSize
  • e78f47e: 8283347: [macos] Bad JNI lookup accessibilityHitTest is shown when Screen magnifier is enabled
  • b5e8388: 8283187: C2: loop candidate for superword not always unrolled fully if superword fails
  • c923449: 8281822: Test failures on non-DTrace builds due to incomplete DTrace* flags handling
  • efabf45: 8280940: gtest os.release_multi_mappings_vm is racy
  • 83dba03: 8281522: Rename ADLC classes which have the same name as hotspot variants
  • ba4e609: 8282382: Report glibc malloc tunables in error reports
  • bf6b1d9: 8274939: Incorrect size of the pixel storage is used by the robot on macOS
  • ... and 7 more: https://git.openjdk.java.net/jdk17u-dev/compare/2875e18190957bb49e5f7ec275fba68119e5f096...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 8, 2022
@openjdk openjdk bot closed this Apr 8, 2022
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Apr 8, 2022
@TheRealMDoerr TheRealMDoerr deleted the 8279822_CI_constant_pool branch April 8, 2022 15:54
@openjdk openjdk bot removed the rfr Pull request is ready for review label Apr 8, 2022
@openjdk
Copy link

openjdk bot commented Apr 8, 2022

@TheRealMDoerr Pushed as commit da9aa23.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants