Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283217: Leak FcObjectSet in getFontConfigLocations() in fontpath.c #336

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Apr 5, 2022

A clean and low risk backport to fix memory leak


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8283217: Leak FcObjectSet in getFontConfigLocations() in fontpath.c

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/336/head:pull/336
$ git checkout pull/336

Update a local copy of the PR:
$ git checkout pull/336
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/336/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 336

View PR using the GUI difftool:
$ git pr show -t 336

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/336.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 5, 2022

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 909986c7e110c8ac3ba16750be7707b1ec344ee5 8283217: Leak FcObjectSet in getFontConfigLocations() in fontpath.c Apr 5, 2022
@openjdk
Copy link

openjdk bot commented Apr 5, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 5, 2022

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283217: Leak FcObjectSet in getFontConfigLocations() in fontpath.c

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 5, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 5, 2022

Webrevs

@zhengyu123
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 10, 2022

Going to push as commit c390fbc.
Since your change was applied there have been 5 commits pushed to the master branch:

  • da9aa23: 8279822: CI: Constant pool entries in error state are not supported
  • fcc1cc6: 8276880: Remove java/lang/RuntimeTests/exec/ExecWithDir as unnecessary
  • d218ce4: 8284369: TestFailedAllocationBadGraph fails with -XX:TieredStopAtLevel < 4
  • 7d3a528: 8283279: [Testbug] Improve TestGetSwapSpaceSize
  • e78f47e: 8283347: [macos] Bad JNI lookup accessibilityHitTest is shown when Screen magnifier is enabled

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 10, 2022
@openjdk openjdk bot closed this Apr 10, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 10, 2022
@openjdk
Copy link

openjdk bot commented Apr 10, 2022

@zhengyu123 Pushed as commit c390fbc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant