Skip to content

8303770: Remove Baltimore root certificate expiring in May 2025 #3367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 17, 2025

I backport this for parity with 17.0.16-oracle.

I had to adapt location and the test, as it is always the case with changes to the certs.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8303770 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8303770: Remove Baltimore root certificate expiring in May 2025 (Task - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3367/head:pull/3367
$ git checkout pull/3367

Update a local copy of the PR:
$ git checkout pull/3367
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3367/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3367

View PR using the GUI difftool:
$ git pr show -t 3367

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3367.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 17, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 17, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303770: Remove Baltimore root certificate expiring in May 2025

Reviewed-by: sgehwolf, rschmelter

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 8ba5d80: 8352076: [21u] Problem list tests that fail in 21 and would be fixed by 8309622
  • 07d2927: 8340784: Remove PassFailJFrame constructor with screenshots
  • 767e504: 8347286: (fs) Remove some extensions from java/nio/file/Files/probeContentType/Basic.java
  • 735747a: 8346581: JRadioButton/ButtonGroupFocusTest.java fails in CI on Linux
  • 552566a: 8334644: Automate javax/print/attribute/PageRangesException.java
  • b9b9d7f: 8341637: java/net/Socket/UdpSocket.java fails with "java.net.BindException: Address already in use" (macos-aarch64)
  • f8eaafc: 8340985: Open source some Desktop related tests
  • c2e5dc0: 8340164: Open source few Component tests - Set1
  • fa98869: 8256211: assert fired in java/net/httpclient/DependentPromiseActionsTest (infrequent)
  • 86975d6: 8293503: gc/metaspace/TestMetaspacePerfCounters.java#Epsilon-64 failed assertGreaterThanOrEqual: expected MMM >= NNN

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 2371696781edc040d8fa8133c78b284a2e3de1ed 8303770: Remove Baltimore root certificate expiring in May 2025 Mar 17, 2025
@openjdk
Copy link

openjdk bot commented Mar 17, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 17, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 17, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 17, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

Copy link
Contributor

@schmelter-sap schmelter-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@GoeLin
Copy link
Member Author

GoeLin commented Mar 18, 2025

Thanks for the reviews!

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Mar 18, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Mar 20, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Mar 20, 2025

Going to push as commit 4e67796.
Since your change was applied there have been 26 commits pushed to the master branch:

  • 763ee0a: 8348110: Update LCMS to 2.17
  • dda39ec: 8280991: [XWayland] No displayChanged event after setDisplayMode call
  • e31723b: 8345598: Upgrade NSS binaries for interop tests
  • 3a0e19b: 8350260: Improve HTML instruction formatting in PassFailJFrame
  • 3d76ae0: 8294155: Exception thrown before awaitAndCheck hangs PassFailJFrame
  • 011a970: 8342524: Use latch in AbstractButton/bug6298940.java instead of delay
  • 5fdaafb: 8343936: Adjust timeout in test javax/management/monitor/DerivedGaugeMonitorTest.java
  • d0a02d0: 8343103: Enable debug logging for vmTestbase/nsk/jvmti/scenarios/sampling/SP05/sp05t003/TestDescription.java
  • 36f9ed8: 8337221: CompileFramework: test library to conveniently compile java and jasm sources for fuzzing
  • 4fa11fe: 8340809: Open source few more AWT PopupMenu tests
  • ... and 16 more: https://git.openjdk.org/jdk17u-dev/compare/fd50c1722380ce419bd5ac7f1318d1a808f87ec5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 20, 2025
@openjdk openjdk bot closed this Mar 20, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 20, 2025
@openjdk
Copy link

openjdk bot commented Mar 20, 2025

@GoeLin Pushed as commit 4e67796.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8303770 branch March 20, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants