JDK-8283347: [macos] Bad JNI lookup accessibilityHitTest is shown when Screen magnifier is enabled

[MBaesken]

Hi, we get unwanted exceptions on macOS in jdk17 when Screen magnifier is enabled.
Looks like this was caused by a wrong placing of GET_CACCESSIBILITY_CLASS_RETURN in
(id)accessibilityHitTest:(NSPoint)point .

It was placed after the DECLARE_CLASS_RETURN and DECLARE_STATIC_METHOD_RETURN clauses. That is incorrect. So after i moved it up before the DECLARE_CLASS_RETURN clause the bug stops reproducing.
Thanks to Alexander Zuev for the analysis.

Best regards, Matthias

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8283347: [macos] Bad JNI lookup accessibilityHitTest is shown when Screen magnifier is enabled

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/338/head:pull/338
$ git checkout pull/338

Update a local copy of the PR:
$ git checkout pull/338
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/338/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 338

View PR using the GUI difftool:
$ git pr show -t 338

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/338.diff

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (90a7df68)

[TheRealMDoerr]

LGTM. Thanks for fixing!

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283347: [macos] Bad JNI lookup accessibilityHitTest is shown when Screen magnifier is enabled

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[MBaesken]

/integrate

[openjdk]

Going to push as commit e78f47e.

[openjdk]

@MBaesken Pushed as commit e78f47e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.