Skip to content

8352302: Test sun/security/tools/jarsigner/TimestampCheck.java is failing #3383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 19, 2025

This needs to be fixed in 17, too.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8352302 needs maintainer approval

Issue

  • JDK-8352302: Test sun/security/tools/jarsigner/TimestampCheck.java is failing (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3383/head:pull/3383
$ git checkout pull/3383

Update a local copy of the PR:
$ git checkout pull/3383
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3383/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3383

View PR using the GUI difftool:
$ git pr show -t 3383

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3383.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 19, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 19, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352302: Test sun/security/tools/jarsigner/TimestampCheck.java is failing

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 577ede73d8e916bac9050d3bee80d2f18cc833a7 8352302: Test sun/security/tools/jarsigner/TimestampCheck.java is failing Mar 19, 2025
@openjdk
Copy link

openjdk bot commented Mar 19, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 19, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 19, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 19, 2025

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Mar 20, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Mar 20, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Mar 20, 2025

Going to push as commit b2255b9.
Since your change was applied there have been 17 commits pushed to the master branch:

  • 4e67796: 8303770: Remove Baltimore root certificate expiring in May 2025
  • 763ee0a: 8348110: Update LCMS to 2.17
  • dda39ec: 8280991: [XWayland] No displayChanged event after setDisplayMode call
  • e31723b: 8345598: Upgrade NSS binaries for interop tests
  • 3a0e19b: 8350260: Improve HTML instruction formatting in PassFailJFrame
  • 3d76ae0: 8294155: Exception thrown before awaitAndCheck hangs PassFailJFrame
  • 011a970: 8342524: Use latch in AbstractButton/bug6298940.java instead of delay
  • 5fdaafb: 8343936: Adjust timeout in test javax/management/monitor/DerivedGaugeMonitorTest.java
  • d0a02d0: 8343103: Enable debug logging for vmTestbase/nsk/jvmti/scenarios/sampling/SP05/sp05t003/TestDescription.java
  • 36f9ed8: 8337221: CompileFramework: test library to conveniently compile java and jasm sources for fuzzing
  • ... and 7 more: https://git.openjdk.org/jdk17u-dev/compare/8ba5d8046e684203778a80183ec4a6f441631ba5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 20, 2025
@openjdk openjdk bot closed this Mar 20, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 20, 2025
@openjdk
Copy link

openjdk bot commented Mar 20, 2025

@GoeLin Pushed as commit b2255b9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant