8277983: Remove unused fields from sun.net.www.protocol.jar.JarURLConnection#3406
8277983: Remove unused fields from sun.net.www.protocol.jar.JarURLConnection#3406cost0much wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back cost0much! A progress list of the required criteria for merging this PR into |
|
@cost0much This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 14 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request Enhancement change from JDK19 and already in JDK21. I want to backport bug fix JDK-6956385 but it doesn't apply cleanly due to this change. Applies cleanly and passes tier1 tests. Risk is low given in JDK21 and no change to logic. |
|
@cost0much |
|
/integrate |
|
@cost0much |
|
/sponsor |
|
Going to push as commit 96e8c56.
Your commit was automatically rebased without conflicts. |
|
@Rudometov @cost0much Pushed as commit 96e8c56. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Clean backport. Enhancement that doesn't make any logic changes; I'd like to backport the bug fix JDK-6956385 but it doesn't apply cleanly because of this change, so backporting this first.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3406/head:pull/3406$ git checkout pull/3406Update a local copy of the PR:
$ git checkout pull/3406$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3406/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3406View PR using the GUI difftool:
$ git pr show -t 3406Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3406.diff
Using Webrev
Link to Webrev Comment