Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284389: Improve stability of GHA Pre-submit testing by caching cygwin installer #341

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Apr 7, 2022

Hi all,

This pull request contains a clean backport of JDK-8284389.

The commit being backported was authored by Christoph Langer on 7 Apr 2022 and was reviewed by Aleksey Shipilev.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8284389: Improve stability of GHA Pre-submit testing by caching cygwin installer

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/341/head:pull/341
$ git checkout pull/341

Update a local copy of the PR:
$ git checkout pull/341
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/341/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 341

View PR using the GUI difftool:
$ git pr show -t 341

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/341.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 7, 2022

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 61fcf2f67ff16bee92a5279e7bcacc79fc8f37ad 8284389: Improve stability of GHA Pre-submit testing by caching cygwin installer Apr 7, 2022
@openjdk
Copy link

openjdk bot commented Apr 7, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 7, 2022

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284389: Improve stability of GHA Pre-submit testing by caching cygwin installer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 7, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 7, 2022

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Apr 8, 2022

What is the problem with the Pre-submit tests?

@RealCLanger
Copy link
Contributor Author

What is the problem with the Pre-submit tests?

I think this should be clear by the bug description. But in short words here: We recently saw issues when the GHA job downloaded the cygwin installer. curl timed out for whatever reason. The intent is to mitigate this a bit by caching the installer. With some luck we could find it in the cache. And, furthermore, errors like this should only bubble up in the build step but never in the test step now. (We had tests where the build could download the cygwin installer but a bit later the test step failed.)

@GoeLin
Copy link
Member

GoeLin commented Apr 11, 2022

That was not the question. Why did the presubmit tests on macOS fail? Is this related to your change? Please make sure that is unrelated before you push. Thanks.

@RealCLanger
Copy link
Contributor Author

That was not the question. Why did the presubmit tests on macOS fail? Is this related to your change? Please make sure that is unrelated before you push. Thanks.

Ah, I see. 😄 Seems like the one macos test step got stuck for some reason. However, others finished successfully and also my change doesn't touch the macos flow at all. So it's 99.999% unrelated.

@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 11, 2022

Going to push as commit a0822b0.
Since your change was applied there have been 5 commits pushed to the master branch:

  • c11b74b: 8276863: Remove test/jdk/sun/security/ec/ECDSAJavaVerify.java
  • c390fbc: 8283217: Leak FcObjectSet in getFontConfigLocations() in fontpath.c
  • da9aa23: 8279822: CI: Constant pool entries in error state are not supported
  • fcc1cc6: 8276880: Remove java/lang/RuntimeTests/exec/ExecWithDir as unnecessary
  • d218ce4: 8284369: TestFailedAllocationBadGraph fails with -XX:TieredStopAtLevel < 4

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 11, 2022
@openjdk openjdk bot closed this Apr 11, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 11, 2022
@openjdk
Copy link

openjdk bot commented Apr 11, 2022

@RealCLanger Pushed as commit a0822b0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants