Skip to content

8348597: Update HarfBuzz to 10.4.0 #3413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 31, 2025

I backport this for parity with 17.0.16-oracle.

I had to resolve the makefile.
The same file is edited as in 21, but the listed warning flags
differ, so this can not be a clean backport from 21.
It differs to head as the make code is in an other file.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8348597 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8348597: Update HarfBuzz to 10.4.0 (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3413/head:pull/3413
$ git checkout pull/3413

Update a local copy of the PR:
$ git checkout pull/3413
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3413/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3413

View PR using the GUI difftool:
$ git pr show -t 3413

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3413.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 31, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 31, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8348597: Update HarfBuzz to 10.4.0

Reviewed-by: mbaesken, phh
Backport-of: dbdbbd473061d7e8077ed07ccc6b03065a8c2ffc

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 845a11e: 8287801: Fix test-bugs related to stress flags
  • 692f275: 8350211: CTW: Attempt to preload all classes in constant pool
  • 01425e4: 6956385: URLConnection.getLastModified() leaks file handles for jar:file and file: URLs
  • 41b3541: 8298061: vmTestbase/nsk/sysdict/vm/stress/btree/btree012/btree012.java failed with "fatal error: refcount has gone to zero"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport dbdbbd473061d7e8077ed07ccc6b03065a8c2ffc 8348597: Update HarfBuzz to 10.4.0 Mar 31, 2025
@openjdk
Copy link

openjdk bot commented Mar 31, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 31, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 31, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 31, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@MBaesken
Copy link
Member

MBaesken commented Apr 1, 2025

why do we have 186 file changes but in head or 21u-dev 193 ? this looks strange to me .

Copy link
Member

@MBaesken MBaesken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the files !

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 2, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Apr 2, 2025

Thanks for spotting the file problem and the review!

@GoeLin
Copy link
Member Author

GoeLin commented Apr 2, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Apr 2, 2025

Going to push as commit f4e99de.
Since your change was applied there have been 12 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 2, 2025
@openjdk openjdk bot closed this Apr 2, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 2, 2025
@openjdk
Copy link

openjdk bot commented Apr 2, 2025

@GoeLin Pushed as commit f4e99de.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8348597 branch April 2, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants