-
Notifications
You must be signed in to change notification settings - Fork 224
8348597: Update HarfBuzz to 10.4.0 #3413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
|
why do we have 186 file changes but in head or 21u-dev 193 ? this looks strange to me . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the files !
Thanks for spotting the file problem and the review! |
/integrate |
Going to push as commit f4e99de.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 17.0.16-oracle.
I had to resolve the makefile.
The same file is edited as in 21, but the listed warning flags
differ, so this can not be a clean backport from 21.
It differs to head as the make code is in an other file.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3413/head:pull/3413
$ git checkout pull/3413
Update a local copy of the PR:
$ git checkout pull/3413
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3413/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3413
View PR using the GUI difftool:
$ git pr show -t 3413
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3413.diff
Using Webrev
Link to Webrev Comment