Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283422: Create a new test for JDK-8254790 #346

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Apr 12, 2022

Hi all,

This pull request contains a backport of commit ad83ec7e from the openjdk/jdk repository.

The commit being backported was authored by Sergey Bylokhov on 31 Mar 2022 and was reviewed by Vladimir Kozlov and Tobias Hartmann.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/346/head:pull/346
$ git checkout pull/346

Update a local copy of the PR:
$ git checkout pull/346
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/346/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 346

View PR using the GUI difftool:
$ git pr show -t 346

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/346.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 12, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ad83ec7e281cb3ab7c42e71fab47ea21b93079ea 8283422: Create a new test for JDK-8254790 Apr 12, 2022
@openjdk
Copy link

openjdk bot commented Apr 12, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 12, 2022

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283422: Create a new test for JDK-8254790

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 03eb709: 8283725: Launching java with "-Xlog:gc*=trace,safepoint*=trace,class*=trace" crashes the JVM
  • 99eb134: 8279520: SPNEGO has not passed channel binding info into the underlying mechanism

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 12, 2022
@mrserb mrserb marked this pull request as ready for review April 25, 2022 01:04
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 25, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 25, 2022

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Apr 25, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Apr 25, 2022

Going to push as commit 2a799c8.
Since your change was applied there have been 27 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 25, 2022
@openjdk openjdk bot closed this Apr 25, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 25, 2022
@openjdk
Copy link

openjdk bot commented Apr 25, 2022

@mrserb Pushed as commit 2a799c8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant