Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283725: Launching java with "-Xlog:gc*=trace,safepoint*=trace,class*=trace" crashes the JVM #347

Closed

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Apr 12, 2022

Hi all,

I'd like to backport this fix to prevent the JVM from crashing.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8283725: Launching java with "-Xlog:gc*=trace,safepoint*=trace,class*=trace" crashes the JVM

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/347/head:pull/347
$ git checkout pull/347

Update a local copy of the PR:
$ git checkout pull/347
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/347/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 347

View PR using the GUI difftool:
$ git pr show -t 347

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/347.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 12, 2022

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1ca0ede60d961a1355397f27fd78a177432c7bc3 8283725: Launching java with "-Xlog:gc*=trace,safepoint*=trace,class*=trace" crashes the JVM Apr 12, 2022
@openjdk
Copy link

openjdk bot commented Apr 12, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 12, 2022

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283725: Launching java with "-Xlog:gc*=trace,safepoint*=trace,class*=trace" crashes the JVM

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 99eb134: 8279520: SPNEGO has not passed channel binding info into the underlying mechanism

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 12, 2022
@tstuefe tstuefe marked this pull request as ready for review Apr 13, 2022
@openjdk openjdk bot added the rfr label Apr 13, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 13, 2022

Webrevs

@tstuefe
Copy link
Member Author

tstuefe commented Apr 13, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Apr 13, 2022

Going to push as commit 03eb709.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 99eb134: 8279520: SPNEGO has not passed channel binding info into the underlying mechanism

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Apr 13, 2022
@openjdk openjdk bot closed this Apr 13, 2022
@openjdk openjdk bot removed ready rfr labels Apr 13, 2022
@openjdk
Copy link

openjdk bot commented Apr 13, 2022

@tstuefe Pushed as commit 03eb709.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant