Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277777: [Vector API] assert(r->is_XMMRegister()) failed: must be in x86_32.ad #35

Closed

Conversation

DamonFool
Copy link
Member

@DamonFool DamonFool commented Dec 23, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8277777: [Vector API] assert(r->is_XMMRegister()) failed: must be in x86_32.ad

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/35/head:pull/35
$ git checkout pull/35

Update a local copy of the PR:
$ git checkout pull/35
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/35/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 35

View PR using the GUI difftool:
$ git pr show -t 35

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/35.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 23, 2021

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 349328c929ccad242a344da69585404e4fea087f 8277777: [Vector API] assert(r->is_XMMRegister()) failed: must be in x86_32.ad Dec 23, 2021
@openjdk
Copy link

openjdk bot commented Dec 23, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 23, 2021

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277777: [Vector API] assert(r->is_XMMRegister()) failed: must be in x86_32.ad

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 81cd594: 8276314: [JVMCI] check alignment of call displacement during code installation

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 23, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 23, 2021

Webrevs

@DamonFool
Copy link
Member Author

Fix request had been approved.
So integrate it.
Thanks.

@DamonFool
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 27, 2021
@openjdk
Copy link

openjdk bot commented Dec 27, 2021

@DamonFool
Your change (at version a4680c1) is now ready to be sponsored by a Committer.

@johnshajiang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 27, 2021

Going to push as commit d8a22d6.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 81cd594: 8276314: [JVMCI] check alignment of call displacement during code installation

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 27, 2021
@openjdk openjdk bot closed this Dec 27, 2021
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 27, 2021
@openjdk
Copy link

openjdk bot commented Dec 27, 2021

@johnshajiang @DamonFool Pushed as commit d8a22d6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants