8312475: org.jline.util.PumpReader signed byte problem

[Baraa-Hasheesh]

Clean Backport JDK-8312475: SonarCloud reports a possible issue in read method

• buffer.get() reads a signed byte so it has a range of -128-127
• When end of file is reached the read method returns -1 signed integer

When the buffer.get() reads -1 => it returns 0xFF as a signed byte value, this causes the SonarCloud to confuse the possibility that the -1 byte value (0xFF), equals the -1 EOF value (0xFFFFFFFF)

This simply added a casting to & 0xFF to avoid this confusion.

---

Progress

• JDK-8312475 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8312475: org.jline.util.PumpReader signed byte problem (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3536/head:pull/3536
$ git checkout pull/3536

Update a local copy of the PR:
$ git checkout pull/3536
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3536/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3536

View PR using the GUI difftool:
$ git pr show -t 3536

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3536.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back Baraa-Hasheesh! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Baraa-Hasheesh This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312475: org.jline.util.PumpReader signed byte problem

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 94 new commits pushed to the master branch:

• 4241313: 8354941: Build failure with glibc 2.42 due to uabs() name collision
• ac37921: 8264207: CodeStrings does not honour fixed address assumption.
• f453734: 8295005: compiler/loopopts/TestRemoveEmptyLoop.java fails with release VMs after JDK-8294839
• ... and 91 more: https://git.openjdk.org/jdk17u-dev/compare/d132468950815df952e38869f304445502631f52...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @Baraa-Hasheesh This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (a6c22efe)

[Baraa-Hasheesh]

/approval request Fixes a false reporting issue in SonarCloud due to confusion between -1(Byte) & -1(int) values. Applies cleanly. tier1 tests passes. Risk is minimal as no real change in code behaviour was made.

[openjdk]

@Baraa-Hasheesh
8312475: The approval request has been created successfully.

[Baraa-Hasheesh]

/approval request Solve a false reporting issue in SonarCloud due to confusion between -1(Byte) & -1(int) values, applies cleanly, tier1 tests passes.

[openjdk]

@Baraa-Hasheesh
8312475: The approval request has been updated successfully.

[bridgekeeper]

@Baraa-Hasheesh This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[Baraa-Hasheesh]

/keepalive

[openjdk]

@Baraa-Hasheesh The pull request is being re-evaluated and the inactivity timeout has been reset.

[Baraa-Hasheesh]

/integrate

[openjdk]

@Baraa-Hasheesh
Your change (at version a6c22ef) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit f7492dd.
Since your change was applied there have been 94 commits pushed to the master branch:

• 4241313: 8354941: Build failure with glibc 2.42 due to uabs() name collision
• ac37921: 8264207: CodeStrings does not honour fixed address assumption.
• f453734: 8295005: compiler/loopopts/TestRemoveEmptyLoop.java fails with release VMs after JDK-8294839
• ... and 91 more: https://git.openjdk.org/jdk17u-dev/compare/d132468950815df952e38869f304445502631f52...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @Baraa-Hasheesh Pushed as commit f7492dd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.