8349501: Relocate supporting classes in security/testlibrary to test/lib/jdk tree

[GoeLin]

I backport this for parity with 17.0.16-oracle based on the change in 21.

The patch of 21 applies clean except for two tests that are not in 17:

test/jdk/java/security/cert/CertPathValidator/crlDP/CheckAllCRLs.java
Added by "https://bugs.openjdk.org/browse/JDK-8200566: DistributionPointFetcher fails to fetch CRLs if the DistributionPoints field contains more than one DistributionPoint and the first one fails". A P4 bugfix I don't want to backport to 17.

test/jdk/sun/security/pkcs12/GetSetEntryTest.java
Added by "https://bugs.openjdk.org/browse/JDK-8327461: KeyStore getEntry is not thread-safe" which has another prereq. Don't backport to 17.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8349501 needs maintainer approval

Issue

• JDK-8349501: Relocate supporting classes in security/testlibrary to test/lib/jdk tree (Bug - P4 - Approved)

Reviewers

• Ralf Schmelter (@schmelter-sap - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3539/head:pull/3539
$ git checkout pull/3539

Update a local copy of the PR:
$ git checkout pull/3539
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3539/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3539

View PR using the GUI difftool:
$ git pr show -t 3539

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3539.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349501: Relocate supporting classes in security/testlibrary to test/lib/jdk tree

Reviewed-by: rschmelter

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 23901f3: 8333680: com/sun/tools/attach/BasicTests.java fails with "SocketException: Permission denied: connect"
• 6d38efa: 8288707: javax/swing/JToolBar/4529206/bug4529206.java: setFloating does not work correctly

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (c7c69b88)

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[schmelter-sap]

Looks good.

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[GoeLin]

/integrate

[openjdk]

Going to push as commit e559962.
Since your change was applied there have been 6 commits pushed to the master branch:

• 9abc9ce: 8303549: [AIX] TestNativeStack.java is failing with exit value 1
• 22c205d: 8295670: Remove duplication in java/util/Formatter/Basic*.java
• 2035332: 8295470: Update openjdk.java.net => openjdk.org URLs in test code
• ... and 3 more: https://git.openjdk.org/jdk17u-dev/compare/af0de21b9bac2b593e2b50703e2995cd7a9cfb42...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit e559962.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.