8314319: LogCompilation doesn't reset lateInlining when it encounters a failure.

[satyenme]

Backporting JDK-8314319: LogCompilation doesn't reset lateInlining when it encounters a failure. Fixes issue where compilation encounters a failure after it processes '<late_inline>' tag, and, in cases where the C2 compiler retries after tweaking options it omits subsume_load. Adds test. Ran GHA Sanity Checks, local Tier 1 and 2 tests. Patch is clean.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8314319 needs maintainer approval

Warning

 ⚠️ Found trailing period in issue title for 8314319: LogCompilation doesn't reset lateInlining when it encounters a failure.

Issue

• JDK-8314319: LogCompilation doesn't reset lateInlining when it encounters a failure. (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3545/head:pull/3545
$ git checkout pull/3545

Update a local copy of the PR:
$ git checkout pull/3545
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3545/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3545

View PR using the GUI difftool:
$ git pr show -t 3545

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3545.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@satyenme This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314319: LogCompilation doesn't reset lateInlining when it encounters a failure.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 307d548: 8355429: Open source ProgressMonitor test
• dd495ab: 8354285: Open source Swing tests Batch 3
• 7e92579: 8353655: Clean up and open source KeyEvent related tests (Part 1)
• ... and 3 more: https://git.openjdk.org/jdk17u-dev/compare/6666153eb41ee0bbc5907eec8daf5b329af6e48e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 01: Full - Incremental (92d5336f)
• 00: Full (7878efe9)

[satyenme]

/approval request for backport. One line fix to address issue where compilation encounters a failure after it processes '<late_inline>' tag, and, in cases where the C2 compiler retries after tweaking options, it omits subsume_load

Risk: Low. Tip change was merged in September 2023 and PR adds a test to confirm functionality.

Testing:

• GHA Sanity Checks
• Tier 1 and 2 tests locally
• src/utils/LogCompilation/src/test/java/com/sun/hotspot/tools/compiler/TestPrebuiltLogs.java

[openjdk]

@satyenme
8314319: The approval request has been created successfully.

[GoeLin]

Hi @satyenme
Do you still want to bring this to 17? If so, please merge head for new testing and reopen this change.

[GoeLin]

I remove the label in the meantime.

[satyenme]

Thanks for following up, lost track of this, but think it's still worth proceeding with - I've merged head, reran testing and will add another approval request.

[satyenme]

/approval request for backport. One line fix to address issue where compilation encounters a failure after it processes '<late_inline>' tag, and, in cases where the C2 compiler retries after tweaking options, it omits subsume_load

Risk: Low. Tip change was merged in September 2023 and PR adds a test to confirm functionality. Touches logCompilation, but is a one line change, easy to reason through.

Testing:

• GHA Sanity Checks
• Tier 1 and 2 tests locally
• src/utils/LogCompilation/src/test/java/com/sun/hotspot/tools/compiler/TestPrebuiltLogs.java

[openjdk]

@satyenme
8314319: The approval request has been updated successfully.

[satyenme]

/integrate

[openjdk]

Going to push as commit aabe830.
Since your change was applied there have been 8 commits pushed to the master branch:

• c6e19d6: 8350807: Certificates using MD5 algorithm that are disabled by default are incorrectly allowed in TLSv1.3 when re-enabled
• c3f9905: 8355370: Include server name in HTTP test server thread names to improve diagnostics
• 307d548: 8355429: Open source ProgressMonitor test
• ... and 5 more: https://git.openjdk.org/jdk17u-dev/compare/6666153eb41ee0bbc5907eec8daf5b329af6e48e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@satyenme Pushed as commit aabe830.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.