Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284023: java.sun.awt.X11GraphicsDevice.getDoubleBufferVisuals() leaks XdbeScreenVisualInfo #355

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Apr 22, 2022

A clean, low risk backport to fix a memory leak


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8284023: java.sun.awt.X11GraphicsDevice.getDoubleBufferVisuals() leaks XdbeScreenVisualInfo

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/355/head:pull/355
$ git checkout pull/355

Update a local copy of the PR:
$ git checkout pull/355
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/355/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 355

View PR using the GUI difftool:
$ git pr show -t 355

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/355.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 22, 2022

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ec205f68a883cef6b98f26a06baf675f7da26928 8284023: java.sun.awt.X11GraphicsDevice.getDoubleBufferVisuals() leaks XdbeScreenVisualInfo Apr 22, 2022
@openjdk
Copy link

openjdk bot commented Apr 22, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 22, 2022

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284023: java.sun.awt.X11GraphicsDevice.getDoubleBufferVisuals() leaks XdbeScreenVisualInfo

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 22, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 22, 2022

Webrevs

@zhengyu123
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 4, 2022

Going to push as commit 75cfc99.
Since your change was applied there have been 45 commits pushed to the master branch:

  • cf2b20f: 8284532: Memory leak in BitSet::BitMapFragmentTable in JFR leak profiler
  • 70d3583: 8282170: JVMTI SetBreakpoint metaspace allocation test
  • 0955aca: 8285394: Compiler blackholes can be eliminated due to stale ciMethod::intrinsic_id()
  • db26df6: 8284549: JFR: FieldTable leaks FieldInfoTable member
  • a1da138: 8284620: CodeBuffer may leak _overflow_arena
  • c1e1719: 8274735: javax.imageio.IIOException: Unsupported Image Type while processing a valid JPEG image
  • bb7b764: 8279529: ProblemList java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on macosx-aarch64
  • 40c7bf2: 8282293: Domain value for system property jdk.https.negotiate.cbt should be case-insensitive
  • d67ca11: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos
  • ae9b334: 8280684: JfrRecorderService failes with guarantee(num_written > 0) when no space left on device.
  • ... and 35 more: https://git.openjdk.java.net/jdk17u-dev/compare/03eb709ea93e3bf0975f2686523e5d590b6a14f8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 4, 2022
@openjdk openjdk bot closed this May 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 4, 2022
@openjdk
Copy link

openjdk bot commented May 4, 2022

@zhengyu123 Pushed as commit 75cfc99.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant