Skip to content

8330534: Update nsk/jdwp tests to use driver instead of othervm#3559

Closed
GoeLin wants to merge 3 commits intoopenjdk:masterfrom
GoeLin:goetz_backport_8330534
Closed

8330534: Update nsk/jdwp tests to use driver instead of othervm#3559
GoeLin wants to merge 3 commits intoopenjdk:masterfrom
GoeLin:goetz_backport_8330534

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented May 7, 2025

I backport this for parity with 17.0.17-oracle.

Resolved Copyright in test/hotspot/jtreg/vmTestbase/nsk/jdwp/Event/EXCEPTION/exception001.java,
probably clean anyways.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8330534 needs maintainer approval

Issue

  • JDK-8330534: Update nsk/jdwp tests to use driver instead of othervm (Sub-task - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3559/head:pull/3559
$ git checkout pull/3559

Update a local copy of the PR:
$ git checkout pull/3559
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3559/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3559

View PR using the GUI difftool:
$ git pr show -t 3559

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3559.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 7, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into pr/3558 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 7, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8330534: Update nsk/jdwp tests to use driver instead of othervm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 56e8e60792b23bc101f46b497dcc9d3c76855384 8330534: Update nsk/jdwp tests to use driver instead of othervm May 7, 2025
@openjdk
Copy link

openjdk bot commented May 7, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review labels May 7, 2025
@mlbridge
Copy link

mlbridge bot commented May 7, 2025

Webrevs

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received and removed approval Requires approval; will be removed when approval is received labels May 8, 2025
@GoeLin GoeLin changed the base branch from pr/3558 to master May 8, 2025 09:14
@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 8, 2025
@GoeLin
Copy link
Member Author

GoeLin commented May 8, 2025

/integrate

@openjdk
Copy link

openjdk bot commented May 8, 2025

Going to push as commit bdc6ab5.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 8, 2025
@openjdk openjdk bot closed this May 8, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 8, 2025
@openjdk
Copy link

openjdk bot commented May 8, 2025

@GoeLin Pushed as commit bdc6ab5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8330534 branch May 8, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant