Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280684: JfrRecorderService failes with guarantee(num_written > 0) when no space left on device. #357

Closed

Conversation

jbachorik
Copy link

@jbachorik jbachorik commented Apr 25, 2022


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8280684: JfrRecorderService failes with guarantee(num_written > 0) when no space left on device.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/357/head:pull/357
$ git checkout pull/357

Update a local copy of the PR:
$ git checkout pull/357
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/357/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 357

View PR using the GUI difftool:
$ git pr show -t 357

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/357.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 25, 2022

👋 Welcome back jbachorik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9471f24ca191832669a13e5a1ea73f7097a25927 8280684: JfrRecorderService failes with guarantee(num_written > 0) when no space left on device. Apr 25, 2022
@openjdk
Copy link

openjdk bot commented Apr 25, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 25, 2022

@jbachorik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280684: JfrRecorderService failes with guarantee(num_written > 0) when no space left on device.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 25, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 25, 2022

Webrevs

@jbachorik jbachorik closed this Apr 26, 2022
@jbachorik jbachorik deleted the jbachorik-backport-9471f24c branch April 26, 2022 11:32
@jbachorik jbachorik restored the jbachorik-backport-9471f24c branch April 26, 2022 11:37
@jbachorik jbachorik reopened this Apr 26, 2022
@jbachorik
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 28, 2022

Going to push as commit ae9b334.
Since your change was applied there have been 35 commits pushed to the master branch:

  • b751b3c: 8285445: cannot open file "NUL:"
  • 1cbe38a: 8284458: CodeHeapState::aggregate() leaks blob_name
  • 6793a6a: 8284866: Add test to JDK-8273056
  • 740e6b1: 8278519: serviceability/jvmti/FieldAccessWatch/FieldAccessWatch.java failed "assert(handle != __null) failed: JNI handle should not be null"
  • 6f109a4: 8277396: [TESTBUG] In DefaultButtonModelCrashTest.java, frame is accessed from main thread
  • 11d3c00: 8273095: vmTestbase/vm/mlvm/anonloader/stress/oome/heap/Test.java fails with "wrong OOME"
  • 73c292a: 8282142: [TestCase] compiler/inlining/ResolvedClassTest.java will fail when --with-jvm-features=-compiler1
  • b18783d: 8285342: Zero build failure with clang due to values not handled in switch
  • 90d4233: 8284622: Update versions of some Github Actions used in JDK workflow
  • 2a799c8: 8283422: Create a new test for JDK-8254790
  • ... and 25 more: https://git.openjdk.java.net/jdk17u-dev/compare/03eb709ea93e3bf0975f2686523e5d590b6a14f8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 28, 2022
@openjdk openjdk bot closed this Apr 28, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 28, 2022
@openjdk
Copy link

openjdk bot commented Apr 28, 2022

@jbachorik Pushed as commit ae9b334.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jbachorik jbachorik deleted the jbachorik-backport-9471f24c branch May 2, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant