Skip to content

8273095: vmTestbase/vm/mlvm/anonloader/stress/oome/heap/Test.java fails with "wrong OOME" #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Apr 25, 2022

Clean backport of testfix JDK-8273095
Test is not problem listed in 17u and therefore this PR is not automatically recognized as clean backport.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273095: vmTestbase/vm/mlvm/anonloader/stress/oome/heap/Test.java fails with "wrong OOME"

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/360/head:pull/360
$ git checkout pull/360

Update a local copy of the PR:
$ git checkout pull/360
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/360/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 360

View PR using the GUI difftool:
$ git pr show -t 360

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/360.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 25, 2022

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f62b81c3b5e34895e06bedec137bcef701d49df6 8273095: vmTestbase/vm/mlvm/anonloader/stress/oome/heap/Test.java fails with "wrong OOME" Apr 25, 2022
@openjdk
Copy link

openjdk bot commented Apr 25, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Apr 25, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 25, 2022

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

/clean

@openjdk openjdk bot added the clean label Apr 25, 2022
@openjdk
Copy link

openjdk bot commented Apr 25, 2022

@TheRealMDoerr This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Apr 25, 2022

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273095: vmTestbase/vm/mlvm/anonloader/stress/oome/heap/Test.java fails with "wrong OOME"

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 25, 2022
@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 27, 2022

Going to push as commit 11d3c00.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 73c292a: 8282142: [TestCase] compiler/inlining/ResolvedClassTest.java will fail when --with-jvm-features=-compiler1
  • b18783d: 8285342: Zero build failure with clang due to values not handled in switch
  • 90d4233: 8284622: Update versions of some Github Actions used in JDK workflow
  • 2a799c8: 8283422: Create a new test for JDK-8254790

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 27, 2022
@openjdk openjdk bot closed this Apr 27, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 27, 2022
@openjdk
Copy link

openjdk bot commented Apr 27, 2022

@TheRealMDoerr Pushed as commit 11d3c00.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8273095_oome_test branch April 27, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant